Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbWCJIqb (ORCPT ); Fri, 10 Mar 2006 03:46:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932716AbWCJIqa (ORCPT ); Fri, 10 Mar 2006 03:46:30 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:50582 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932715AbWCJIqa (ORCPT ); Fri, 10 Mar 2006 03:46:30 -0500 Subject: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) From: Arjan van de Ven To: Kirill Korotaev Cc: Andrew Morton , Linux Kernel Mailing List , Al Viro , devel@openvz.org, Andrey Savochkin In-Reply-To: <44113CCC.5080602@openvz.org> References: <44113CCC.5080602@openvz.org> Content-Type: text/plain Date: Fri, 10 Mar 2006 09:46:25 +0100 Message-Id: <1141980385.2876.30.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 25 On Fri, 2006-03-10 at 11:46 +0300, Kirill Korotaev wrote: > Andrew, > > Fixed both comments from Al Viro (thanks, Al): > - should have a separate helper > - should pass 0 instead of GFP_KERNEL in page_symlink() > > + page = find_or_create_page(mapping, 0, > + mapping_gfp_mask(mapping) | gfp_mask); this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit more. As such a | operation isn't going to be useful.... (So I think that while Al's intention was good, the implication of it isn't ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/