Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR
From:   Chanwoo Choi <cw00.choi@samsung.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Leonard Crestez <leonard.crestez@nxp.com>
Cc:     linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Organization: Samsung Electronics
Message-ID: <7dc02882-3317-20cc-450c-23abc23d5cb5@samsung.com>
Date:   Fri, 8 May 2020 12:57:55 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <82fc7219-b9c7-c5fa-10b1-692f6a5ed411@samsung.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200507130824epcas1p287961e0a2f5019a55ecd1c94772fdfff@epcas1p2.samsung.com>
        <20200507131245.GA709@embeddedor>
        <82fc7219-b9c7-c5fa-10b1-692f6a5ed411@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/8/20 12:55 PM, Chanwoo Choi wrote:
> On 5/7/20 10:12 PM, Gustavo A. R. Silva wrote:
>> Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().
>>
>> The proper pointer to be passed as argument to PTR_ERR() is
>> priv->icc_pdev.
>>
>> This bug was detected with the help of Coccinelle.
>>
>> Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>>  drivers/devfreq/imx-bus.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
>> index 532e7954032f..4f38455ad742 100644
>> --- a/drivers/devfreq/imx-bus.c
>> +++ b/drivers/devfreq/imx-bus.c
>> @@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
>>  			dev, icc_driver_name, -1, NULL, 0);
>>  	if (IS_ERR(priv->icc_pdev)) {
>>  		dev_err(dev, "failed to register icc provider %s: %ld\n",
>> -				icc_driver_name, PTR_ERR(priv->devfreq));
>> -		return PTR_ERR(priv->devfreq);
>> +				icc_driver_name, PTR_ERR(priv->icc_pdev));
>> +		return PTR_ERR(priv->icc_pdev);
>>  	}
>>  
>>  	return 0;
>>
> 
> Applied it. Thanks.
> 

I edit the patch title as following:
- before : PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR
- after  : PM / devfreq: imx-bus: Fix inconsistent IS_ERR and PTR_ERR

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics