Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1390795ybj; Thu, 7 May 2020 23:42:06 -0700 (PDT) X-Google-Smtp-Source: APiQypIA/nG+tVbaPPYDkH26JBn3fD4DpW0UTLXQhcmZ4uQWS+RCID84yj9Qf59xBNvxOpWnYtAa X-Received: by 2002:a05:6402:1768:: with SMTP id da8mr926880edb.216.1588920125779; Thu, 07 May 2020 23:42:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588920125; cv=none; d=google.com; s=arc-20160816; b=LB63f68JhWTXq3itxmjAEXl8X8oC9wn+rn7rNw/A+/tHZF0gIFdwz3b49hNQLQoARv f6dcsGP8Vef9lzfVUAIA679mid1Mjq9HWcHLRIVp5MhYAvPsrMDPOrUOEHDYfgMQzd7Q G973SfAwZeqlo1clyxRqm0xlZJKCHZDpR2Yc5e+5B2D/ozBrpZenZ0Kx1H85SN3IU/M0 wQc/G3tobDy71GSx7+A95YsMmZdox9tDDSKoNKzS06A9vVc+DYAuqyKm8lXQx7GsfOmx SdXraNA7S+kO/MY3vsw5GcYojPm6WxbavVv0ifK/Q0FeS2YhLHaszVoZXfrDYbQopxSv /qRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qiQcUnaOsTuYIdMr9pQhA9E0vZ/bgcYyUJ6NKwIoiA8=; b=h72Yq+NsUm3YnDAy5ilyD/3pbUwRadoWSYeSFGe4RhuV4tM7XaKLd7FCxIcR1DS4Dw GPDYm5vSj8JDbBG77JcLf09hpsi+0bUJiRJD9/Bgc/uMcjQBHMvfmcF3muiImmWTwN8G NJik4VZvrluhHidX6iz/mlTzZm6XkWRt/JluycyUbHxr+H+L+wDNir644qD+lUURdkEE iDiH/mh8ZQtBkIJkawqN7CvgaT/5dVvyByZaYBGuqzaU3OyRaR4HMkucb4QpXiTYagys tIwhRRtrkvsAnoaDwF2bhGpHg5bAkSpkjR9GVdXcOm3F6iXEVhaO2K91ZDb4GM0Rkz+A /rWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AGitAEjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si479333edq.326.2020.05.07.23.41.43; Thu, 07 May 2020 23:42:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AGitAEjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgEHGkP (ORCPT + 99 others); Fri, 8 May 2020 02:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726897AbgEHGkO (ORCPT ); Fri, 8 May 2020 02:40:14 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BB3FC05BD09 for ; Thu, 7 May 2020 23:40:14 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id z1so446471pfn.3 for ; Thu, 07 May 2020 23:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiQcUnaOsTuYIdMr9pQhA9E0vZ/bgcYyUJ6NKwIoiA8=; b=AGitAEjAmIYuKXy+lG43wJaRD8vsDY21A7oS+DPw/WXhdya0M2b77Hp2SjGy4IDeA7 0mXKCAbk5gyUBklW+6pHdkHCR05KcSgPpdfyhoVoNan7SFIeqEK/VVjckLgwFwrYPTDZ OpOCzvcEaiQZBjlPAHAPh8sFU5hMWxw/60ScM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiQcUnaOsTuYIdMr9pQhA9E0vZ/bgcYyUJ6NKwIoiA8=; b=A6b9cXEcPUP9UF88XfwTQsAoKgryqwhN4a27XT5GoHEen0mR8WIR9FKC0urffCzBM9 kSBLlUxiTgPzkn6PgfwNmF/yApKiveuRCCoIFQ4bl8bGWKBPNETuvvUybsvkhYnLjBHD uDXk1ii6dRpa+okhTYk181sn14mKgJcsNlMO1TAJCwHa96TBFHsoeOAp5GgQJg0jiiuB vsVO30kfVKmrOesb19vYz6fkpUX28uXZgoQUQxRaoIIAyje95nZU3i/CgKxDw+oHgrEc SB+SIU4GhgupUm0DXn4hnprvbMuX2waPsYksP0jd0FSAA8kdqp1bEo1TnAjzZRKzyeu8 xsIA== X-Gm-Message-State: AGi0PuZ2JF9udLHQ7bDoG3qqQMAfqUZtLOtMA7pEnOSBru87+hRcFbFB wQuBuifSpWdFhMwq+e4G5D9kWA== X-Received: by 2002:a63:b649:: with SMTP id v9mr832219pgt.402.1588920013880; Thu, 07 May 2020 23:40:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 140sm757265pfw.96.2020.05.07.23.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 23:40:12 -0700 (PDT) From: Kees Cook To: WeiXiong Liao Cc: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-doc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device Date: Thu, 7 May 2020 23:39:52 -0700 Message-Id: <20200508064004.57898-1-keescook@chromium.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! This is a v4 of WeiXiong Liao's series. I spent time porting this on top of the latest pstore (mainly to support max_reason), and I started making various other changes, mostly just bikeshed stuff. Changes since v3: fixing up various typos, alternate phrases, and language. For example: recorder -> frontend Pstore -> pstore filenames: rename pstore_*.c -> *.c and adjust Makefile (I decided fs/pstore/pstore_zone.c repeated "pstore" one too many time. ;) pstore-block.rst -> pstore_blk.rst conversion of dump_oops -> max_reason refactor/rename get_reason_str() and move to kernel/printk/printk.c psz* -> pstore_zone* renamings: psblk_usr_info() ->... pstore_blk_usr_info() psz_zone -> pstore_zone pszinfo -> pstore_zone_info register_pstore_zone(): registration reporting via pr_cont(), with max_reason remove needless get/put_module() public API renamings: VERB_NOUN() psz_*register() -> *register_pstore_zone() v3: https://lore.kernel.org/lkml/1585126506-18635-1-git-send-email-liaoweixiong@allwinnertech.com/ v2: https://lore.kernel.org/lkml/1581078355-19647-1-git-send-email-liaoweixiong@allwinnertech.com/ v1: https://lore.kernel.org/lkml/1579482233-2672-1-git-send-email-liaoweixiong@allwinnertech.com/ So far, I've identified the following stuff left to do: - settle on various function/struct renamings - review locking - implement ramoops-like probe feature for pstore/blk - spend time seeing how ramoops might use pstore/zone But I wanted to get this update published just to show what I've done so far in my bikeshed review. :) Thanks! -Kees Kees Cook (1): printk: Introduce kmsg_dump_reason_str() WeiXiong Liao (11): pstore/zone: Introduce common layer to manage storage zones pstore/blk: Introduce backend for block devices pstore/blk: Provide way to choose pstore frontend support pstore/blk: Add support for pmsg frontend pstore/blk: Add console frontend support pstore/blk: Add ftrace frontend support Documentation: Add details for pstore/blk pstore/zone: Provide way to skip "broken" zone for MTD devices pstore/blk: Provide way to query pstore configuration pstore/blk: Support non-block storage devices mtd: Support kmsg dumper based on pstore/blk Documentation/admin-guide/pstore-blk.rst | 243 ++++ MAINTAINERS | 1 + drivers/mtd/Kconfig | 10 + drivers/mtd/Makefile | 1 + drivers/mtd/mtdpstore.c | 564 ++++++++ fs/pstore/Kconfig | 109 ++ fs/pstore/Makefile | 6 + fs/pstore/blk.c | 481 +++++++ fs/pstore/platform.c | 22 +- fs/pstore/zone.c | 1498 ++++++++++++++++++++++ include/linux/kmsg_dump.h | 7 + include/linux/pstore_blk.h | 77 ++ include/linux/pstore_zone.h | 60 + kernel/printk/printk.c | 21 + 14 files changed, 3079 insertions(+), 21 deletions(-) create mode 100644 Documentation/admin-guide/pstore-blk.rst create mode 100644 drivers/mtd/mtdpstore.c create mode 100644 fs/pstore/blk.c create mode 100644 fs/pstore/zone.c create mode 100644 include/linux/pstore_blk.h create mode 100644 include/linux/pstore_zone.h -- 2.20.1