Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1391287ybj; Thu, 7 May 2020 23:43:02 -0700 (PDT) X-Google-Smtp-Source: APiQypLnNQRGhqhYbqBrqGoUmzBsMH/yjMAcQ8oTPbo4aAruglcUKJw1QGHyocwGGIw6izeR11uY X-Received: by 2002:a05:6402:28e:: with SMTP id l14mr887749edv.184.1588920182326; Thu, 07 May 2020 23:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588920182; cv=none; d=google.com; s=arc-20160816; b=UjcsYFjv3Htjg1xmUP46RV1wiEQnf9OzyZmVVr9FPEIw0FbaSHR8VJ2uYQk3aBHGBu 2DQiwX3rEF6jfGHJbT4wMA7fgwnpNdUNK4MJnMT0AJCYFhyuw4VYEhmQlpiME+ZRuFYY Vr2z/WvGGnM/xhEP9TDBUS3P8+xWXjP0CHuNEtUkyKRqPTDmU0BZaOAuuXvuWk3JzsSj GMvH+5IdNhpCoQX5xMrUMrwbA38WngP64/7s34mGxePK0YP6ofMrpM0cdhL7e6zWMtM7 PrKK7XUX56tL8//DqbpyRoUfh40kOIyoT5aJlJIc8qUPWatkANwzVUfyiR/HJ7D2Y9A1 ijuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rt7LaaONSgmUksm2yx3P247YW6uNXuBJExGFoYIoUvk=; b=V1D2fM103W2mHdx7ZOLctI33gWVHM7rSC2dx6djR86y9EYfkD/+mnEgN/24VWxRcKy j4AnzQSKnIaZzH5pCUUnsxWwsru4Ank7M+veDareZIgG3F+zydKo9TFtsuLrzwNn4Efm Bofd9cXEBX7SFgiQUp6QzzAy6QQX/xqzlXwg7oZC12w9QmtpJYAnykFpDnNsSCc9Z2n/ zoyFWqRctPBCZirtLkzAWLoGVSNinWkmYhXt1D656QW7f20B7UeGDVmcvGEJ0fiFz6p7 O+OPtGaAg8ZEhvWZvleF+i4kLHlaTh+cOhfaTwpcq4eqRlpuaT+KnrucK2CEqtKyPNq+ +3pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si466278edv.332.2020.05.07.23.42.37; Thu, 07 May 2020 23:43:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725971AbgEHGjB (ORCPT + 99 others); Fri, 8 May 2020 02:39:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727071AbgEHGjA (ORCPT ); Fri, 8 May 2020 02:39:00 -0400 Received: from nibbler.cm4all.net (nibbler.cm4all.net [IPv6:2001:8d8:970:e500:82:165:145:151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D75C05BD09 for ; Thu, 7 May 2020 23:39:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by nibbler.cm4all.net (Postfix) with ESMTP id E8B33C02BC for ; Fri, 8 May 2020 08:38:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at nibbler.cm4all.net Received: from nibbler.cm4all.net ([127.0.0.1]) by localhost (nibbler.cm4all.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BMHn56dk6HsY for ; Fri, 8 May 2020 08:38:58 +0200 (CEST) Received: from zero.intern.cm-ag (zero.intern.cm-ag [172.30.16.10]) by nibbler.cm4all.net (Postfix) with SMTP id C8E6CC0280 for ; Fri, 8 May 2020 08:38:58 +0200 (CEST) Received: (qmail 3890 invoked from network); 8 May 2020 09:55:18 +0200 Received: from unknown (HELO rabbit.intern.cm-ag) (172.30.3.1) by zero.intern.cm-ag with SMTP; 8 May 2020 09:55:18 +0200 Received: by rabbit.intern.cm-ag (Postfix, from userid 1023) id 9F32F461450; Fri, 8 May 2020 08:38:58 +0200 (CEST) From: Max Kellermann To: axboe@kernel.dk, linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Max Kellermann Subject: [PATCH v2 2/2] fs/io_uring: remove unused flag fd_non_neg Date: Fri, 8 May 2020 08:38:46 +0200 Message-Id: <20200508063846.21067-2-mk@cm4all.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200508063846.21067-1-mk@cm4all.com> References: <20200508063846.21067-1-mk@cm4all.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --- fs/io_uring.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index d24f8e33323c..0aa7cd547ced 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -604,8 +604,6 @@ struct io_op_def { unsigned needs_mm : 1; /* needs req->file assigned */ unsigned needs_file : 1; - /* needs req->file assigned IFF fd is >= 0 */ - unsigned fd_non_neg : 1; /* hash wq insertion if file is a regular file */ unsigned hash_reg_file : 1; /* unbound wq insertion if file is a non-regular file */ @@ -4572,8 +4570,6 @@ static int io_req_needs_file(struct io_kiocb *req, int fd) { if (!io_op_defs[req->opcode].needs_file) return 0; - if ((fd == -1 || fd == AT_FDCWD) && io_op_defs[req->opcode].fd_non_neg) - return 0; return 1; } -- 2.20.1