Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wrWiUH2nDG04ZJI2f9ZHRxw3tXG7PuhVCPtQonXjDx+C+5X3asw1ewy1rEChoEVrOOkJubSaTJ
 +nohaahzaTOC/tGcJ4GPOp8OzH0/qqOvaxLRhHElvqR5m58/dyig3zpXe0j7yQv1fuziol0hla
 NW/3I6ZNdWIGzI9QJDT6p64lITf12DkH0W2wexU9xPnxT2zdOiIZZxu01JGVgzuZ7Kb4lxwI4h
 kzlqG2pSYiLpEZRKO3SvP0xuEA1Hlavki6mEYgAYYjEV59l9+X8R4+up4rcqL+xC4a/o79GzdL
 mtg=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Stanley Chu <stanley.chu@mediatek.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>
CC:     "beanhuo@micron.com" <beanhuo@micron.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
        "peter.wang@mediatek.com" <peter.wang@mediatek.com>,
        "chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
        "andy.teng@mediatek.com" <andy.teng@mediatek.com>
Subject: RE: [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for
 WriteBooster
Thread-Topic: [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for
 WriteBooster
Thread-Index: AQHWJQ7gr0gnpM8U7069v+wIJ9OSoqid3i3w
Date:   Fri, 8 May 2020 08:40:00 +0000
Message-ID: <SN6PR04MB464039C499F73656FA92014CFCA20@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200508080115.24233-1-stanley.chu@mediatek.com>
In-Reply-To: <20200508080115.24233-1-stanley.chu@mediatek.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f8cbc1f-a14e-4e66-1321-08d7f32b654d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 08:40:00.4138
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zdg8X/2c83x+lmseifTavHxzqyn3hsRMZLbv2BdOMTmGoqEs5qDNpZfkwb+RXwVJmfSK3i0FhELvG2/qea9nnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5104
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This series looks good to me.
Thanks,
Avri

>=20
>=20
> Hi,
> This patchset adds LU dedicated buffer mode support for WriteBooster.
> In the meanwhile, enable WriteBooster capability on MediaTek UFS
> platforms.
>=20
> v7 -> v8:
>   - In exported funtion ufshcd_fixup_dev_quirks(), add null checking for
> parameter "fixups" (Avri Altman)
>=20
> v6 -> v7:
>   - Add device descriptor length check in ufshcd_wb_probe() back to preve=
nt
> out-of-boundary access in ufshcd_wb_probe()
>   - Fix the check of device descriptor length (Avri Altman)
>   - Provide a new ufs_fixup_device_setup() function to pack both device f=
ixup
> methods by general quirk table and vendor-specific way (Avri Altman)
>=20
> v5 -> v6:
>   - Remove device descriptor length check in ufshcd_wb_probe()
>=20
> v4 -> v5:
>   - Check LUN ID for available WriteBooster buffer only from 0 to 7 accor=
ding
> to spec (Avri Altman)
>   - Skip checking any possible errors from ufshcd_read_unit_desc_param(hb=
a,
> lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and
> check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri
> Altman)
>=20
> v3 -> v4:
>   - Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify
> device quirks, and provide an initial vendor-specific device quirk table =
on
> MediaTek UFS platforms
>   - Avoid relying on common device quirk table for pre-3.1 UFS device wit=
h
> non-standard WriteBooster support (Can Guo)
>   - Fix comments for ufshcd_wb_probe() (Can Guo)
>   - Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (=
Avri
> Altman)
>=20
> v2 -> v3:
>   - Introduce a device quirk to support WriteBooster in pre-3.1 UFS devic=
es
> (Avri Altman)
>   - Fix WriteBooster related sysfs nodes. Now all WriteBooster related sy=
sfs
> nodes are specifically mapped to the LUN with WriteBooster enabled in LU
> Dedicated buffer mode (Avri Altman)
>=20
> v1 -> v2:
>   - Change the definition name of WriteBooster buffer mode to correspond
> to specification (Bean Huo)
>   - Add patch #5: "scsi: ufs: cleanup WriteBooster feature"
>=20
> Stanley Chu (8):
>   scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices
>   scsi: ufs: introduce fixup_dev_quirks vops
>   scsi: ufs: export ufs_fixup_device_setup() function
>   scsi: ufs-mediatek: add fixup_dev_quirks vops
>   scsi: ufs: add "index" in parameter list of ufshcd_query_flag()
>   scsi: ufs: add LU Dedicated buffer mode support for WriteBooster
>   scsi: ufs-mediatek: enable WriteBooster capability
>   scsi: ufs: cleanup WriteBooster feature
>=20
>  drivers/scsi/ufs/ufs-mediatek.c |  25 ++++-
>  drivers/scsi/ufs/ufs-sysfs.c    |  11 ++-
>  drivers/scsi/ufs/ufs.h          |  10 ++
>  drivers/scsi/ufs/ufs_quirks.h   |   7 ++
>  drivers/scsi/ufs/ufshcd.c       | 166 +++++++++++++++++++++-----------
>  drivers/scsi/ufs/ufshcd.h       |  19 +++-
>  6 files changed, 176 insertions(+), 62 deletions(-)
>=20
> --
> 2.18.0