Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1e9dca38dba71b0a8437f752db5f97cab789af60.camel@gmail.com>
Subject: Re: [RESENT PATCH RFC v3 1/5] scsi; ufs: add device descriptor for
 Host Performance Booster
From:   Bean Huo <huobean@gmail.com>
To:     Bart Van Assche <bvanassche@acm.org>, alim.akhtar@samsung.com,
        avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, tomas.winkler@intel.com, rdunlap@infradead.org
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org, cang@codeaurora.org
Date:   Fri, 08 May 2020 11:09:10 +0200
In-Reply-To: <6d06ec34-04d2-93ff-1ff5-dc1317c3d060@acm.org>
References: <20200504142032.16619-1-beanhuo@micron.com>
         <20200504142032.16619-2-beanhuo@micron.com>
         <6d06ec34-04d2-93ff-1ff5-dc1317c3d060@acm.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 17:59 -0700, Bart Van Assche wrote:
> On 2020-05-04 07:20, huobean@gmail.com wrote:
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 698e8d20b4ba..de13d2333f1f 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -6627,6 +6627,17 @@ static int ufs_get_device_desc(struct
> > ufs_hba *hba)
> >  		goto out;
> >  	}
> >  
> > +	if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) {
> > +		hba->dev_info.hpb_control_mode =
> > +			desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE];
> > +		hba->dev_info.hpb_ver =
> > +			(u16) (desc_buf[DEVICE_DESC_PARAM_HPB_VER] <<
> > 8) |
> > +			desc_buf[DEVICE_DESC_PARAM_HPB_VER + 1];
> > +		dev_info(hba->dev, "HPB Version: 0x%2x\n",
> > +			 hba->dev_info.hpb_ver);
> > +		dev_info(hba->dev, "HPB control mode: %d\n",
> > +			 hba->dev_info.hpb_control_mode);
> > +	}
> >  	/*
> >  	 * getting vendor (manufacturerID) and Bank Index in big endian
> >  	 * format
> 
> Please introduce a symbolic name for the constant 0x80, e.g.
> UFS_FEATURE_HPB.
> 
> Please use get_unaligned_be16() instead of open-coding it.
> 
> Thanks,
> 
> Bart.
> 
> 
Bart
thanks, I will change them in the next version.

thanks.

Bean