Subject: Re: [PATCH] EDAC: core EDAC support code
From: Arjan van de Ven <arjan@infradead.org>
To: Tim Small <tim@buttersideup.com>
Cc: Dave Peterson <dsp@llnl.gov>, Greg KH <greg@kroah.com>,
       linux-kernel@vger.kernel.org, Doug Thompson <dthompson@lnxi.com>,
       bluesmoke-devel@lists.sourceforge.net
In-Reply-To: <44115DA4.604@buttersideup.com>
References: <200601190414.k0J4EZCV021775@hera.kernel.org>
	 <200603091551.25097.dsp@llnl.gov> <20060310000227.GA30236@kroah.com>
	 <200603091746.51686.dsp@llnl.gov>
	 <1141976218.2876.2.camel@laptopd505.fenrus.org>
	 <44115DA4.604@buttersideup.com>
Content-Type: text/plain
Date: Fri, 10 Mar 2006 12:40:35 +0100
Message-Id: <1141990836.2876.42.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1314
Lines: 33

On Fri, 2006-03-10 at 11:06 +0000, Tim Small wrote:
> Arjan van de Ven wrote:
> 
> > It depends on how many PCI devices in your machine you wish to
> >
> >>blacklist or whitelist.  The motivation for this feature is that
> >>certain known badly-designed devices report an endless stream of
> >>spurious PCI bus parity errors.  We want to skip such devices when
> >>checking for PCI bus parity errors.
> >>    
> >>
> >
> >ok so this is actually a per pci device property!
> >I would suggest moving this property to the pci device itself, not doing
> >it inside an edac directory.
> >  
> >
> Yes, this seems more sensible to me.  For one thing, I suspect that just 
> keying on vendor:device is probably too blunt for this and that 
> blacklisting a particular PCI device revision is a likely requirement, 
> as well as subsystem vendor/subsystem device.

and maybe even something as funky as firmware version.
So it for sure is a per device (not per ID) property, and something that
needs a global quirk table kind of thing with the option to do per
driver overrides


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/