Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5a88c8a33e77ea2fc086cfbf1aeb1c0b3b6843c2.camel@gmail.com>
Subject: Re: [RESENT PATCH RFC v3 3/5] scsi: ufs: add ufs_features parameter
 in structure ufs_dev_info
From:   Bean Huo <huobean@gmail.com>
To:     Bart Van Assche <bvanassche@acm.org>, alim.akhtar@samsung.com,
        avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, tomas.winkler@intel.com, rdunlap@infradead.org
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org, cang@codeaurora.org
Date:   Fri, 08 May 2020 11:15:43 +0200
In-Reply-To: <f3485a4d-dadd-423a-e186-7736c3bfe5f1@acm.org>
References: <20200504142032.16619-1-beanhuo@micron.com>
         <20200504142032.16619-4-beanhuo@micron.com>
         <f3485a4d-dadd-423a-e186-7736c3bfe5f1@acm.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 18:02 -0700, Bart Van Assche wrote:
> On 2020-05-04 07:20, huobean@gmail.com wrote:
> > From: Bean Huo <beanhuo@micron.com>
> > 
> > Make a copy of bUFSFeaturesSupport, name it ufs_features, add it
> > to structure ufs_dev_info.
> > 
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
> > ---
> >  drivers/scsi/ufs/ufs.h    | 2 ++
> >  drivers/scsi/ufs/ufshcd.c | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
> > index 53a5e263f7c8..1f2d4b4950b8 100644
> > --- a/drivers/scsi/ufs/ufs.h
> > +++ b/drivers/scsi/ufs/ufs.h
> > @@ -543,6 +543,8 @@ struct ufs_dev_info {
> >  	u16 hpb_ver;
> >  	/* bHPBControl */
> >  	u8 hpb_control_mode;
> > +	/* bUFSFeaturesSupport */
> > +	u8 ufs_features;
> >  };
> >  
> >  /**
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index 83ed2879d930..1fe7ffc1a75a 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -6625,6 +6625,8 @@ static int ufs_get_device_desc(struct ufs_hba
> > *hba)
> >  		goto out;
> >  	}
> >  
> > +	dev_info->ufs_features = desc_buf[DEVICE_DESC_PARAM_UFS_FEAT];
> > +
> >  	if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) {
> >  		hba->dev_info.hpb_control_mode =
> >  			desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE];
> 
> Since this patch touches the same code as patch 1/5, please merge
> patches 1/5 and 3/5 into a single patch.
> 
> Thanks,
> 
> Bart.


Bart
you have addressed this in the V2, sorry for this fault.
I will merge them in the next version.

thanks,

Bean
> 
>