Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] KVM: x86/pmu: Support full width counting
To:     like.xu@intel.com, Like Xu <like.xu@linux.intel.com>
Cc:     Sean Christopherson <sean.j.christopherson@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200507021452.174646-1-like.xu@linux.intel.com>
 <3fb56700-7f0b-59e1-527a-f8eb601185b1@redhat.com>
 <72d7d120-85af-d846-a0d5-fe8fe058be34@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <aabf0a54-ff60-5c1e-279b-9c8bf18e396d@redhat.com>
Date:   Fri, 8 May 2020 11:52:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <72d7d120-85af-d846-a0d5-fe8fe058be34@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/05/20 10:42, Xu, Like wrote:
>> Given the bugs, it is clear that you should also modify the pmu.c
>> testcase for kvm-unit-tests to cover full-width writes (and especially
>> the non-full-width write behavior of MSR_IA32_PERFCTRn).  Even before
>> the QEMU side is begin worked on, you can test it with "-cpu
>> host,migratable=off".
>
> Sure, I added some testcases in pmu.c to cover this feature.
> 
> Please review the v3 patch
> https://lore.kernel.org/kvm/20200508083218.120559-1-like.xu@linux.intel.com/
> 
> as well as the kvm-unit-tests testcase.

Awesome, thanks for the quick reply!

Paolo