Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1535612ybj; Fri, 8 May 2020 03:41:50 -0700 (PDT) X-Google-Smtp-Source: APiQypLR6V7sX9ajCEquBYcKQdbqatzeeAdyNDZHaTA+oN+xgK8M1LS8rMNKZKtF2sk63eqf1afY X-Received: by 2002:a05:6402:759:: with SMTP id p25mr1617466edy.102.1588934510239; Fri, 08 May 2020 03:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588934510; cv=none; d=google.com; s=arc-20160816; b=rqVlZr9bMX2b7XrRAbdbsf3fkxr3NE1LbeHDk/EBbwPIJSAZj4cRFrLX5GDYej+cqf FAW/4m6oaSlfAdpRLZ691dsdgOfgtJ368/mJaG/vsybBVwGCRRryybhBoYgA0886zLEP z36ECLxwPmbazvBvBhgSFTBI302e1+rWPz1OF3yZMI8hjYDUJIW/KAix0u4KseEXu3JV e7y5FqmpwTVLXJDLJ7BhYeo18yAyvpJRGlO2a4JprLZLxDIJXc55grBxkhn/Y/22Fogu PwpbPIqjv/STiQcTA3sRuMPi2pyehnQV5lDRPnbHE9zz+XtvQXPHc+gHvZdgwbGhJMwE eiSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=g/+lhpMIuhThJfD23idBZUlUz3NU1ISTpBWH6TO5kvc=; b=WdRd2hLeRrsFOwnvlzin2eRx4vLMSPCtg8yVMcbqZZGMDkBx9EgZFc7Felfg/WiIIf ZUsI1kxFu6jVEwrmEKJ08AUYlciCA+Xy82Ilp4qrjCnCT9+ECF2o5/en14/LGHmI8RnW 3umbmhjvnDVo8m9W2jYjwoe7pYS8GPsoklw3M19svpqyuuHRqy5+s5UdxFziZsO2UYQe 1f/CnMG82pVv7RnCKFlnQIBrqDtghCAKjaRrdN2Kg02T8TBpxnxck7fzdjWGo4e7XD3f lRRzEL83oeEd3Lk2go6V/l2HHHo9wdkr/ei2zGjN5NjASe17S9xw/Gd8GMG9mefM+9Om 36TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="L9//zzjs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dv13si685651ejb.458.2020.05.08.03.41.26; Fri, 08 May 2020 03:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="L9//zzjs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgEHKh0 (ORCPT + 99 others); Fri, 8 May 2020 06:37:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:56180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbgEHKh0 (ORCPT ); Fri, 8 May 2020 06:37:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D90020708; Fri, 8 May 2020 10:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588934244; bh=nMwbkoXsurAgX5aweLzLKtjN+Fg0rJIaQRWh3uGI/70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L9//zzjsKE4ajKoe4iXB7ZnDulXLTyAfrmmFkYLvhvSWi1ElShUtoq+2KWH+yKyn3 303XnjY9Ryc4WBSgBWklZ1DGIyaPBYVXMgcm59qHW21QL6ZkKeac55LnVO23EDzZns 1zqIgPuTHYIL4oia6XGhbFt1/wEeK0cy+3fwG/vQ= Date: Fri, 8 May 2020 12:37:21 +0200 From: Greg KH To: Peter Zijlstra Cc: Quentin Perret , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, fweisbec@gmail.com, tkjos@google.com, kernel-team@android.com Subject: Re: [PATCH 00/14] Modularize schedutil Message-ID: <20200508103721.GA3860390@kroah.com> References: <20200507181012.29791-1-qperret@google.com> <20200508081128.GM5298@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508081128.GM5298@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 10:11:28AM +0200, Peter Zijlstra wrote: > On Thu, May 07, 2020 at 07:09:58PM +0100, Quentin Perret wrote: > > One challenge to implement GKI is to avoid bloating the kernel by > > compiling too many things in, especially given that different devices > > need different things. As such, anything that can be turned into a > > module helps GKI, by offering an alternative to having that component > > built-in. This is true for pretty much anything that can be made > > modular, including drivers as well as other kernel components, such as > > CPUFreq governors. > > The idea is to move to 1 governor, schedutil. Also, I abhor all the > exports this thing does. Modules have no business touching most of that. > > Look at every EXPORT you do and wonder ask yourself how you can abuse > it. Modules are not a good thing, they're horrible pieces of crap. Quentin, what is missing from schedutil that warrants the need for a totally different governor? Is there specific problems with the existing ones or is this just an instance of "we wrote our own a long time ago and never pushed it upstream" from various SoC companies? thanks, greg k-h