Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] tools/bootconfig: fix resource leak in apply_xbc()
To:     Markus Elfring <Markus.Elfring@web.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        "Shiyuan Hu" <hushiyuan@huawei.com>,
        Hewenliang <hewenliang4@huawei.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <3569aa33-8963-966d-9247-ec79b3b3d56d@huawei.com>
 <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de>
From:   Yunfeng Ye <yeyunfeng@huawei.com>
Message-ID: <559edb00-a03b-747e-8ba7-1f16285deefb@huawei.com>
Date:   Fri, 8 May 2020 19:18:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/5/8 19:03, Markus Elfring wrote:
> …
>> +++ b/tools/bootconfig/main.c
>> @@ -314,31 +314,35 @@ int apply_xbc(const char *path, const char *xbc_path)
> …
>> +free_data:
>>  	free(data);
> …
> 
> Would any software users prefer to omit the memory release for
> a quicker program termination?
> 
> Can the commit message become clearer about the explanation for
> the importance of the proposed change?
> 
ok, thanks. this change can fix the warning of tools.

> Regards,
> Markus
> 
>