Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 May 2020 13:32:33 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        andriy.shevchenko@intel.com
Subject: Re: [PATCH] serial: lantiq: Make driver modular and console
 configurable
Message-ID: <20200508113233.GA4043190@kroah.com>
References: <42292519ba78f086eb19d058dec6411f5f29da51.1588936756.git.rahul.tanwar@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42292519ba78f086eb19d058dec6411f5f29da51.1588936756.git.rahul.tanwar@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 08, 2020 at 07:20:49PM +0800, Rahul Tanwar wrote:
> Add changes so Lantiq serial driver can be compiled as a module.
> Also, make this driver's use as console selectable/configurable.

When you say "also" in a patch description, that's usually a huge hint
that this needs to be broken up into multiple patches.

Please do that here, this should be 2.

thanks,

greg k-h