Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1575731ybj; Fri, 8 May 2020 04:45:32 -0700 (PDT) X-Google-Smtp-Source: APiQypL5xsy7ol9a4NjQ0M8TLBpjhWEvZtQ1zmd4tal5N9Mfb/MsiR0HyXMtRFLj8g+Li/mS+sWu X-Received: by 2002:a17:906:9482:: with SMTP id t2mr1458991ejx.241.1588938332284; Fri, 08 May 2020 04:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588938332; cv=none; d=google.com; s=arc-20160816; b=SLl/rZuKCZtF9kNCX/A3Wf/etnd+GPLribjw5PAZatSzmgfyibu8jOFH3YkAUAeI4F Qqp1KvrP2kDUPLoo31k2vwFlS0rQGw2329NwZZf1xftCL9tgnG1qnQOMuocMdSCqyvd1 unv7tL/6dpKZduAUbFFh52Mu+Xa0+9sWKvwY9fF4G04A67TBWVZeEt7wn3NoQYcAJqiz AdvfT+uuKVzAgh1eNZ8ynR2GXsJuZH1x21YdTVH/6CaXz3FcMV/ZsGNPb5C7l+iP8Mq4 /li49HSkhXWbmuv4qbkCRaezuRa9jOYvJShR0h9bkeld0Cs46/draNL+meqbOll+qiRg HvSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=siHZuxYTjeuZLXJRBuLnSOJ+ejUDB55MgHlqxkLJrnM=; b=NFCp781w1Qy89+E30b5bnn5px9p1Tsb/qbgwxW6XrUJyhf6P/ypu5aFdZrm/ErSqNB wc05NYttm6rOuoamHJ+jffhB5JZ3MyW32Tlnmw1NKNCQom7+wHn/izXxvZUUg9N8Bdvh KpFBrkxbitgmbW1nkl8Fg/yWZhziY4Q4Ge118TtgaOhmPpAAXx5pGj4nLJ7zuj+6yNU/ DGcOfaPo0adM/3u9fgZ/qtVcjMRQHPPv2VMxA41H7QEzk4+PscGRpHFwMnFjQdTfbIyA R/5TBU+9XtBUnzvOAmYkduv+HZAol6klF6mAy/ev65G5AHL2VN/wwy2GH7oj6diFGDfH Zwsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si881118ede.147.2020.05.08.04.45.04; Fri, 08 May 2020 04:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726950AbgEHLnU (ORCPT + 99 others); Fri, 8 May 2020 07:43:20 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:47552 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726616AbgEHLnT (ORCPT ); Fri, 8 May 2020 07:43:19 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0DBA5A7C8E54374FEAA2; Fri, 8 May 2020 19:43:18 +0800 (CST) Received: from [127.0.0.1] (10.166.215.237) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Fri, 8 May 2020 19:43:08 +0800 Subject: Re: [v3] tools/bootconfig: fix resource leak in apply_xbc() To: Markus Elfring , Steven Rostedt , Masami Hiramatsu CC: , , "Shiyuan Hu" , Hewenliang , Dan Carpenter References: <3569aa33-8963-966d-9247-ec79b3b3d56d@huawei.com> <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de> <559edb00-a03b-747e-8ba7-1f16285deefb@huawei.com> <65057e82-8002-4ec4-b714-25ac8d05cb68@web.de> From: Yunfeng Ye Message-ID: <938cd0e9-d96b-766c-cfbc-4f0b73d97cd4@huawei.com> Date: Fri, 8 May 2020 19:42:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <65057e82-8002-4ec4-b714-25ac8d05cb68@web.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.166.215.237] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/8 19:30, Markus Elfring wrote: >> this change can fix the warning of tools. > > Would you like to point any specific source code analysis tools out > for this issue? > (Can a corresponding attribution become relevant for a clearer > change description?) > The tools we used is not for open source. it point out some error description like "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c. Can I only description: "Memory and resource leak is found by a static code analysis tools" ? thanks. > Regards, > Markus > >