Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp14927ybj; Fri, 8 May 2020 05:32:41 -0700 (PDT) X-Google-Smtp-Source: APiQypK6NS5oGR/ZDYZaQSkmqHE80mdrWxH0EKW0jDOfCydvTfjz46xcgCSwhlpoWZKZ5kjgZGRk X-Received: by 2002:a17:907:210d:: with SMTP id qn13mr1687890ejb.376.1588941161289; Fri, 08 May 2020 05:32:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588941161; cv=none; d=google.com; s=arc-20160816; b=dkuLmULxZBla7o5vZjDuw3BWO/6OzyjVB3D0e10Sdn78paNkNGPXSGVU1vPRRpN+VJ +TrIpq43CAKlTZmROX4SlMUIZFPg003DkW9GPrpo8gEYWSVhR3XW5DjCBNKd53GLUbYt AX9b9INIkxTdAxOBB3FfEO9YpySsMwtkJHaQ3g28suQYzRW6n/CsF9xh85TPc1kemf3i O3sVyiR5DRgbV/1HGLPQddj7cdtgfAgMRmz1YRyxA0vahOkqPuTDgQTvQNjizjljrOM/ 3DZXbhliJXiQ5FQKuzMUqAUb8Vfj3kAfOKAwR3zDRqa5vp+1x7pxtFRVlppDnb5F/1bW pHYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Jh9usYhMKRqy3NLJENxdFbzz4UTuKOwfTOmzmO7N5OM=; b=BJdW24tXi7KhnGXnYgJ8aUbt0JUGwDyhlMHwCrqEnDDeDsAxcG1Sq+MKIHXr9nRpAw EZdRgPO9tKCuLd0G8OVKX2+5dJilanXY5CgDanhpntMEvl9oqzk5q4U/6kO/hJw0ZZfz mQZ8zexomdA/UnsJJ47hppVxUJ6CXnxhgAfM3OUM/sZvm4BkAvlHe4yagqeDuHYxw6Ca BeLdPlyYOpjOLVkab4kTow/KVr7W9qR5PK60eT+Xvqd7sVf08+trJ4HRPEO8P7GV6iic hfzQpx3Ac+XSnMxEd6tb4smPsj+o0i9ZKkm/0JbvI8z/rhbd6aLLftO+wHKI0xrcchw+ PIKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s27si870751edi.259.2020.05.08.05.32.17; Fri, 08 May 2020 05:32:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726792AbgEHMan (ORCPT + 99 others); Fri, 8 May 2020 08:30:43 -0400 Received: from elvis.franken.de ([193.175.24.41]:44801 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726616AbgEHMan (ORCPT ); Fri, 8 May 2020 08:30:43 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jX29G-00031U-00; Fri, 08 May 2020 14:30:38 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id E727DC0418; Fri, 8 May 2020 14:21:37 +0200 (CEST) Date: Fri, 8 May 2020 14:21:37 +0200 From: Thomas Bogendoerfer To: Serge Semin Cc: Alexey Malahov , Paul Burton , Ralf Baechle , Arnd Bergmann , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Jiaxun Yang , Alexander Lobakin , Huacai Chen , Cedric Hombourger , =?iso-8859-1?Q?Ren=E9?= van Dorst , Ard Biesheuvel , Jessica Yu , Masahiro Yamada , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/20] mips: Add MIPS Warrior P5600 support Message-ID: <20200508122137.GA13177@alpha.franken.de> References: <20200306124807.3596F80307C2@mail.baikalelectronics.ru> <20200506174238.15385-1-Sergey.Semin@baikalelectronics.ru> <20200506174238.15385-8-Sergey.Semin@baikalelectronics.ru> <20200507111735.GF11616@alpha.franken.de> <20200507211923.kfu2ly3ncqms4c2u@mobilestation> <20200508093259.GB9085@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508093259.GB9085@alpha.franken.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 11:32:59AM +0200, Thomas Bogendoerfer wrote: > On Fri, May 08, 2020 at 12:19:23AM +0300, Serge Semin wrote: > > On Thu, May 07, 2020 at 01:17:35PM +0200, Thomas Bogendoerfer wrote: > > > P5600 is CPU_MIPS_R5 so can't you select it here and drop all the || CPU_5600 > > > above/below ? > > > > Alas, We can't do this so easy. CONFIG_CPU_MIPS32_{R2,R5,R6} and any other > > CONFIG_CPU_* configs is something that kernel config-file is supposed to select. > > Their availability is enabled by the CONFIG_SYS_HAS_CPU_* configs. CONFIG_CPU_* > > is supposed to activate CPU-specific features and there is only one > > CONFIG_CPU_x can be enabled at a time seeing it's a part of the "CPU type" > > choice kconfig menu. In addition the CPU config also tunes a compiler to activate > > the arch-specific ISA and optimizations in the arch/mips/Makefile by setting > > -march=cpu-name (where cpu-name can be p5600, mips32r5, etc). > > > > Yes, P5600 is based on the MIPS32r5, but it also has got some specific features > > (see config CPU_P5600 and config MIPS32_R5), which makes it to be different from > > the ancestor. So In addition to the difficulties described above IMHO converting > > CPU_P5600 to a set of features activated on top of the CPU_MIPS32_R5 config > > would contradict the design of the CPU-support configs implemented in the MIPS > > arch subsystem. > > maybe I wasn't clear enough, my suggestion is > > use > > config CPU_P5600 > bool "MIPS Warrior P5600" > depends on SYS_HAS_CPU_P5600 > select CPU_MIPS32_R5 > select CPU_SUPPORTS_UNCACHED_ACCELERATED > select CPU_SUPPORTS_CPUFREQ > select CPU_MIPSR2_IRQ_VI > select CPU_MIPSR2_IRQ_EI > > That way you don't need to any "|| CPU_P5600" where CPU_MIPS32_R5 is > already there. Or are there cases, where this would be wrong ? nevermind, this would also need a select SYS_HAS_CPU_MIPS32_R5, which isn't wanted here. So patch is fine as is. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]