Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1588939255-58038-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1588939255-58038-1-git-send-email-zou_wei@huawei.com>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Fri, 8 May 2020 16:00:31 +0300
Message-ID: <CA+h21hryj+b3wm8JNGW8V9gpF11D6AjdEmhq0FAdunQkPQFFcw@mail.gmail.com>
Subject: Re: [PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'
To:     Samuel Zou <zou_wei@huawei.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        lkml <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Samuel,

On Fri, 8 May 2020 at 14:55, Samuel Zou <zou_wei@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable =E2=80=98pr=
ev_time=E2=80=99 set but not used [-Wunused-but-set-variable]
>   u32 prev_time =3D 0;
>       ^~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
> ---

Thank you for the patch!

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

>  drivers/net/dsa/sja1105/sja1105_vl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c b/drivers/net/dsa/sja11=
05/sja1105_vl.c
> index b52f1af..aa9b0b9 100644
> --- a/drivers/net/dsa/sja1105/sja1105_vl.c
> +++ b/drivers/net/dsa/sja1105/sja1105_vl.c
> @@ -465,7 +465,6 @@ sja1105_gating_cfg_time_to_interval(struct sja1105_ga=
ting_config *gating_cfg,
>         struct sja1105_gate_entry *last_e;
>         struct sja1105_gate_entry *e;
>         struct list_head *prev;
> -       u32 prev_time =3D 0;
>
>         list_for_each_entry(e, &gating_cfg->entries, list) {
>                 struct sja1105_gate_entry *p;
> @@ -476,7 +475,6 @@ sja1105_gating_cfg_time_to_interval(struct sja1105_ga=
ting_config *gating_cfg,
>                         continue;
>
>                 p =3D list_entry(prev, struct sja1105_gate_entry, list);
> -               prev_time =3D e->interval;
>                 p->interval =3D e->interval - p->interval;
>         }
>         last_e =3D list_last_entry(&gating_cfg->entries,
> --
> 2.6.2
>