Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp40736ybj; Fri, 8 May 2020 06:07:48 -0700 (PDT) X-Google-Smtp-Source: APiQypJhBc89vTcCzTqnR1p6UHW/65cAGmfKrT6FpMMzy3CZflD3jDiHO3NqHBMMkrniQXYZdmif X-Received: by 2002:a17:906:d8b4:: with SMTP id qc20mr1773336ejb.253.1588943268444; Fri, 08 May 2020 06:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588943268; cv=none; d=google.com; s=arc-20160816; b=OK2fM5JEntt1+FbqzaRh3Z/wuXidcQgdg5EAV6gdtj8gBL2uzAtFRbiZ6aLNOYipUb h9+WEKrNSwzemvgng8HdFtleoacVjp75JQrQ78JixH/Wpj0jvozuqWHNGZdusn298d6u Gmp3zTipWpd5Qb/3X2vxLbbJFSgfJ4Ki8Owj805SKbYxAHvINEfxix/vaaV7IngHScTV nbiYoGARJcPumr9tEbJwEX/12nwPz/I5Q0QRzRg9a8dF/MRnq82xUW9EUHOn+Cx9al9x stznNJTNeyqwi9mdhKt0Ac/wk1uHuvGsPUCZMnH2UF1ingPAP8aKPU4JcCNYx12GE4aQ 3gag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=/a1ziQU8TedQfYeyU6+eZErYlaCk3fL7l4pI7tbd+GY=; b=wMrVKPx1J1NVE1uc6Ap5UbJhhNN/1ZTAzln/xZbOrZ67aIT+35g4UeRjJHgPffBEdq YdPSCFfADdL8NWGbmvQMy9Q5mCZjvq+h9wEfUdrJp7nBb9woIvGn1jaAUgIUfum53Wnx WYvkgru8v6R7LUHM8R/2unxLCaEFYNlDrlcbQJ3Ik6uJscphL6F8uTmt/38RvJEm3hrF vumkefU60b9Y0U9qcevgx57EDNgQek4cIuMUbMMTyTnojxVtp9UmYQayWUGk2OBS1TUg wsNjchEnLnB9pyEtrt0bKlrmyjZPW93xNGEJemO2Yh5GLiOz19d1Y57yE1M6prT+bl03 s5Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si896658ejr.309.2020.05.08.06.07.23; Fri, 08 May 2020 06:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730610AbgEHNGB (ORCPT + 99 others); Fri, 8 May 2020 09:06:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729815AbgEHNFb (ORCPT ); Fri, 8 May 2020 09:05:31 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF9AC05BD43; Fri, 8 May 2020 06:05:30 -0700 (PDT) Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jX2gw-0007iZ-24; Fri, 08 May 2020 15:05:26 +0200 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id 52FF61C0821; Fri, 8 May 2020 15:05:06 +0200 (CEST) Date: Fri, 08 May 2020 13:05:06 -0000 From: "tip-bot2 for Arnaldo Carvalho de Melo" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/core] perf top: Move sb_evlist to 'struct perf_top' Cc: Jiri Olsa , Adrian Hunter , Namhyung Kim , Song Liu , Arnaldo Carvalho de Melo , x86 , LKML In-Reply-To: <20200429131106.27974-3-acme@kernel.org> References: <20200429131106.27974-3-acme@kernel.org> MIME-Version: 1.0 Message-ID: <158894310626.8414.7965153161723411467.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the perf/core branch of tip: Commit-ID: ca6c9c8b107f9788662117587cd24bbb19cea94d Gitweb: https://git.kernel.org/tip/ca6c9c8b107f9788662117587cd24bbb19cea94d Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 24 Apr 2020 10:40:54 -03:00 Committer: Arnaldo Carvalho de Melo CommitterDate: Tue, 05 May 2020 16:35:29 -03:00 perf top: Move sb_evlist to 'struct perf_top' Where state related to a 'perf top' session is grouped. Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Namhyung Kim Cc: Song Liu Link: http://lore.kernel.org/lkml/20200429131106.27974-3-acme@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 7 +++---- tools/perf/util/top.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 6b067a5..70e1c73 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1580,7 +1580,6 @@ int cmd_top(int argc, const char **argv) OPTS_EVSWITCH(&top.evswitch), OPT_END() }; - struct evlist *sb_evlist = NULL; const char * const top_usage[] = { "perf top []", NULL @@ -1744,9 +1743,9 @@ int cmd_top(int argc, const char **argv) } if (!top.record_opts.no_bpf_event) - bpf_event__add_sb_event(&sb_evlist, &perf_env); + bpf_event__add_sb_event(&top.sb_evlist, &perf_env); - if (perf_evlist__start_sb_thread(sb_evlist, target)) { + if (perf_evlist__start_sb_thread(top.sb_evlist, target)) { pr_debug("Couldn't start the BPF side band thread:\nBPF programs starting from now on won't be annotatable\n"); opts->no_bpf_event = true; } @@ -1754,7 +1753,7 @@ int cmd_top(int argc, const char **argv) status = __cmd_top(&top); if (!opts->no_bpf_event) - perf_evlist__stop_sb_thread(sb_evlist); + perf_evlist__stop_sb_thread(top.sb_evlist); out_delete_evlist: evlist__delete(top.evlist); diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h index 45dc84d..ff83912 100644 --- a/tools/perf/util/top.h +++ b/tools/perf/util/top.h @@ -18,7 +18,7 @@ struct perf_session; struct perf_top { struct perf_tool tool; - struct evlist *evlist; + struct evlist *evlist, *sb_evlist; struct record_opts record_opts; struct annotation_options annotation_opts; struct evswitch evswitch;