Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp113533ybj; Fri, 8 May 2020 07:43:08 -0700 (PDT) X-Google-Smtp-Source: APiQypI4KnurBme4x156CjHteGpKv9c30w1tQDoL7FXuVkw7Iy16lGl8c+2k2iqU4enOZWwu3kuJ X-Received: by 2002:a50:f7c6:: with SMTP id i6mr2224849edn.243.1588948988546; Fri, 08 May 2020 07:43:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588948988; cv=none; d=google.com; s=arc-20160816; b=WTmE+nHNp3V/naEMSxT/znI9znT/tXhgU2FPV1q7iovdsxHA/zvcd1QqYq0fe2YCuS 6ydpwjqpvxlF/T2x69CgKRRV1f4Mq/mLCDYqGf+55/le0yltdKUebnrts9LkrRAWOX0Q hQK/sjrOUOtNgeMPtj99j2pyKN5ILxF9hwPCFwdgLt1AvdJWBAsDZ5Vus4bh5uhaOmOn Ic8d4rsRlJsgz+/zY+2BHzzJM8q4WIY9THo0tZ4bhG/hBrHVMPysCUWOYj60mzf47Z5l L5StFkDwfk5IpIhoODXHnhnfXtzZnC5RAyVlntyTHeBr1nEa0f+/gwFkTfQHa3D6nHOb +j+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9Pd6sdzTLPNAE5lKGbzkZBJdj4O3PQMJ6IPM7eKBgG0=; b=oMhmo3ft7oXeZsRuR2IHh3TsJQscGAdsAyTCr+Xl1Vl81RwlCLYmSwNz1Pp5VtUlcQ +Fe4LMA0JVKW8AeDVaJPs2oXpClwcaJiXGwWpENs2Ep2gCx1+mb+ncZWNvVBN8vwgC1f ngHEeGD2hZJ9nDJPGPqBkt97JYoVT8f/oXyjJCl8em3PEFYtmtO2UiFmKm0HNLmTOXno e0cRqQ/GM72cb+1ksdAD/6y48zOIWjzH/hyor54j8DvdqEUlKQSOQgoyRCRfsxCtfqNn mZ/g5L8Ml9Z+WvpcKZVrljdA5o5loLzO+5w73hsGLwTZ4G7ayWQrJ0NpV26EUAo6YdLe Hs1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zbWum2G0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si1120782edt.120.2020.05.08.07.42.45; Fri, 08 May 2020 07:43:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zbWum2G0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728285AbgEHOlF (ORCPT + 99 others); Fri, 8 May 2020 10:41:05 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:40152 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728174AbgEHOk4 (ORCPT ); Fri, 8 May 2020 10:40:56 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048Ebnqo151224; Fri, 8 May 2020 14:40:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=9Pd6sdzTLPNAE5lKGbzkZBJdj4O3PQMJ6IPM7eKBgG0=; b=zbWum2G0ONLEDe7HujZ8RBdWshb1C66Kikq4kBZLWK8MnHDZeaeAWVUKi69rxnM2H5fF Pp2l5cdPtT+ceGsDz8gE/TLnApl3ov1kZekOJwZETwF3KnIHUBj8ry8oS5/KOiyO7qKb JcZchFi6mTiicfnWuz5J27g+0+geKdvynDn/UJ+w9YDOahr1KYecK+2x95ElNdueXBHM uhSxQbaP90ziupWiHQjPj3nrg4lr3gKPBbe3ariNHs/42VAQ/4MZyczzF7dVDy3BLKHl IUu+XWX3qOYHbspSdU78fuF3wj1oTOjUnMcENgblh0Hxm4FUDPXD8uUZ6h1v5+xomvpr ag== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 30vtewub88-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 14:40:20 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048Eap0a190858; Fri, 8 May 2020 14:40:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 30vtegvcrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 14:40:19 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 048EeHOB002292; Fri, 8 May 2020 14:40:17 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 May 2020 07:40:16 -0700 Date: Fri, 8 May 2020 17:40:09 +0300 From: Dan Carpenter To: Yunfeng Ye Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, rostedt@goodmis.org, kernel-janitors@vger.kernel.org, Shiyuan Hu , Hewenliang Subject: Re: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc() Message-ID: <20200508144009.GQ1992@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=899 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080130 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=946 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080130 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good thanks! Reviewed-by: Dan Carpenter regards, dan carpenter