Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1edda80d569a53e0af28fbe30a367d84f099f8fe.camel@gmail.com>
Subject: Re: [RESENT PATCH RFC v3 5/5] scsi: ufs: UFS Host Performance
 Booster(HPB) driver
From:   Bean Huo <huobean@gmail.com>
To:     Bart Van Assche <bvanassche@acm.org>, alim.akhtar@samsung.com,
        avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org,
        rdunlap@infradead.org
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org
Date:   Fri, 08 May 2020 16:44:57 +0200
In-Reply-To: <7b3e127f-a25f-e821-6704-2680ea619c6d@acm.org>
References: <20200504142032.16619-1-beanhuo@micron.com>
         <20200504142032.16619-6-beanhuo@micron.com>
         <7b3e127f-a25f-e821-6704-2680ea619c6d@acm.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 20:21 -0700, Bart Van Assche wrote:
> On 2020-05-04 07:20, huobean@gmail.com wrote:
> > +config SCSI_UFSHPB
> > +	bool "UFS Host Performance Booster (EXPERIMENTAL)"
> > +	depends on SCSI_UFSHCD
> > +	[ ... ]
> > +
> > +config UFSHPB_MAX_MEM_SIZE
> > +	int "UFS HPB maximum memory size per controller (in MiB)"
> > +	depends on SCSI_UFSHPB
> > +	default 128
> > +	range 0 65536
> > +	[ ... ]
> 
> Kernel module parameters are an inflexible mechanism because the
> value
> of these parameters cannot be changed without rebuilding the kernel
> followed by a reboot. Has it been considered to make these two
> parameters configurable through sysfs? Has it been considered to make
> these parameters UFS device parameters instead of global parameters
> that
> apply to all UFS devices?
> 
> 
Hi Bart
I ever tried these two approaches. let me explain why I finally choose
kernel module "make menuconfig" way.

1: driver module parameter, while system booting, specify maximum HPB
cache size in kernel boot Parameters:

   	static int max_hpb_mem = 128;
   	module_param(max_hpb_mem,int,0444);

but this paramter is added in the ufshcd.c since the ufshpb.c is not a 
independent module. looks not very natural.


2: sysfs parameters

This is a feasible option. we can enable HPB after system boot up,
also, change the HPB cache maximum size.
this is the same with the current way, moreover, we don't want user to
change HPB cache size while HPB is running.


If you prefer to convert current HPB driver to be a kernel module
driver, I prefer first apporach.


thanks,

Bean