Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qHXIFd5na43IW3Wt8mTzKyOpucPbM1rDWcYz0L/11DuoVT5o5iJBsP9k9HLlhgd+DONgrNq7I8
 EikTUwWZ20lg==
IronPort-SDR: XN15M4RZFAHyjTWmo7AtUbiSDyZx81DyK5bKtQiRsCXpzx/sNnNOgIdU1OG0jfg4rvR24YVvk2
 JtBq1K2Ceo0g==
Subject: Re: [PATCH] ASoC: Intel: Boards: Support headset button function for
 nau88l25max and nau88l25ssm
To:     Radoslaw Biernacki <rad@semihalf.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc:     Chinyue Chen <chinyue@chromium.org>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Ben Zhang <benzh@chromium.org>,
        Marcin Wojtas <mw@semihalf.com>,
        Benson Leung <bleung@chromium.org>,
        Alex Levin <levinale@google.com>
References: <20200507220332.24686-1-rad@semihalf.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <39aed974-ee2c-a0e7-9228-304cce275289@linux.intel.com>
Date:   Fri, 8 May 2020 09:45:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200507220332.24686-1-rad@semihalf.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/7/20 5:03 PM, Radoslaw Biernacki wrote:
> Map the buttons from the Android reference headset to
> KEY_PLAYPAUSE, KEY_VOICECOMMAND, KEY_VOLUMEUP, and KEY_VOLUMEDOWN.
> KEY_PLAYPAUSE is used instead of KEY_MEDIA for BTN_0 as it is more
> logical and have much broader userspace support. Like Chrome OS
> use it to play/pause of video and audio. KEY_PLAYPAUSE is also
> supported by Android (USB headset spec requires KEY_PLAYPAUSE
> for BTN_0.)
> https://source.android.com/devices/accessories/headset/usb-headset-spec
> 
> Signed-off-by: Chinyue Chen <chinyue@chromium.org>
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>