Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp123229ybj; Fri, 8 May 2020 07:57:00 -0700 (PDT) X-Google-Smtp-Source: APiQypKZpzgcBAib2RRb4oeMo+jwmbzLdF8Ayr1D/0ny95U5OM1eqMllBH2BaX3B6EQ/Q7U7gM6D X-Received: by 2002:a17:906:3b8b:: with SMTP id u11mr2144001ejf.352.1588949820025; Fri, 08 May 2020 07:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588949820; cv=none; d=google.com; s=arc-20160816; b=cPVtRAjaR61Antf4udFn6L0JnT9x/c55NEw5/99yPyOWtkPf9cFryBWl8/EkS46YIs iEgrETuRnVWiYr8TjcX5FnioDL4yPZtkBfSCq6F8In8vgeS8F/soMceRtMbYK+4Xnm8K ih79he58JcE4nlEa3ZDkN1RTUawEhlsR+F8P5KiS5iHyS0fifKdqe7VWo6rktUOlqgkl uFR8aVifTld5OPZMLE930g5EPj1WMf5oWecEXixoBNyL0WWRbtcnaEk8NBapJqYRhw8F CFH9HsIW4mOmNgBU5L3PGTC0yg2/+qBCOOGikTYxKQFOLdtheGpmHyGw8OkA0jJ6qJjW FqhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=H53MWy6dhP3UdGhQsVHvIU1qakOi+iDSoSFMC+dgrvs=; b=wyagk7iQ1rY8QIYO8HO1QstCT15k4UkikOFmW9YdVpsYAAFPuJcORR6T/EEYbsjUy0 3n+VKXpdoD4qcYEgdynxqyrNAgeAR+jAVpPAUxiZgbCEipsS06o70Ds6poyl+MV+diXB s5RuaJnJUfqCDmJbRczssUPhfijNBDYLV7DVuhPj1IKQrdpLJutaxZ3OIlwNOa8o8No1 wewzMj+QxTlipCiyjcoJ3XzW0Uc0ITMfFv0dmXa+xjWb+4qDXQx8HLPpTHvWBPrdYSq4 QbbqIN53bpUvFSb1yD7reeeu8YDMrTuE6k9Xg23pH9rQg5pqT2UKigz9C7vPj7Aysy6O UrOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KfLsY8G0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si1057143ejb.130.2020.05.08.07.56.36; Fri, 08 May 2020 07:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KfLsY8G0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728165AbgEHOwX (ORCPT + 99 others); Fri, 8 May 2020 10:52:23 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:53528 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728130AbgEHOwW (ORCPT ); Fri, 8 May 2020 10:52:22 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048EnS7G066839; Fri, 8 May 2020 14:51:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=H53MWy6dhP3UdGhQsVHvIU1qakOi+iDSoSFMC+dgrvs=; b=KfLsY8G0zHjnTr9Fba5pSDHbZNgaB3jQUv3bF0bm+60uJ88JModvJ6vqfx/6NsU5Pcgj gNE3Qply8HfD+euxqH5tuIm3rA+T6K1Lz8PZJghoL2tfBAoyczl5pLOSzvISrUlU8wf5 fIg0qZIQklSTxSVCCuZl3i1bNoV3goqzi+57Se8/FJdsPQU2AJJ2FxGaxHpBCVCUm7yD hH5aDOR3i9SKGPdtd+4NkY9JS0edCkTUiD2YjX4zz8M60ZhDfF7PbOw1Oqcx58qggxjY PXRZ1E+LKk82dzk7NXgFzVV2HaGFkf+kpegH4Z3SbnGaHChcvzi7JUlcT9M1GV8x0xfa Pg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 30vtepkcy3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 14:51:45 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 048EkvhN050162; Fri, 8 May 2020 14:51:45 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 30vtdnr041-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 May 2020 14:51:45 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 048EpftU026800; Fri, 8 May 2020 14:51:41 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 May 2020 07:51:41 -0700 Date: Fri, 8 May 2020 17:51:33 +0300 From: Dan Carpenter To: Yunfeng Ye Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, rostedt@goodmis.org, kernel-janitors@vger.kernel.org, Shiyuan Hu , Hewenliang Subject: Re: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc() Message-ID: <20200508145133.GG9365@kadam> References: <20200508144009.GQ1992@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508144009.GQ1992@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 mlxlogscore=785 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080132 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9614 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=846 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005080132 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 05:40:09PM +0300, Dan Carpenter wrote: > Looks good thanks! > > Reviewed-by: Dan Carpenter I was also absolutely fine with the v3 patch as well. regards, dan carpenter