Date: Fri, 10 Mar 2006 18:50:54 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [rfc] Collie battery status sensing code
Message-ID: <20060310175054.GC8018@elf.ucw.cz>
References: <20060309123842.GA3619@elf.ucw.cz> <1141910391.10107.49.camel@localhost.localdomain> <20060305001254.GA2423@ucw.cz> <1141924371.10107.75.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1141924371.10107.75.camel@localhost.localdomain>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1296
Lines: 31

Hi!

> > I thought about it, and considered it quite ugly. Result would be all
> > data on the platform bus with half-empty device on ucb1x00 "bus". It
> > would bring me some problems with registering order: if platform
> > device is registered too soon, ucb will be NULL and it will crash and
> > burn. OTOH I already have static *ucb, so it is doable, and I can do
> > it if you prefer it that way...
> 
> If you register the sharpsl-pm device in the collie_pm_add() function,
> ucb should always have registered by that point? As you say, you already
> have the static *ucb and I'm hoping using the platform device will mean
> less invasive changes in sharpsl_pm itself in the future?

Well, difference is not going to be 

> For the record, this patch from Dirk Opfer also exists. He's working on
> using sharpsl-pm on tosa.
> 
> http://www.rpsys.net/openzaurus/patches/archive/sharpsl_pm-do-r2.patch

Yep, looks nice, and will be useful for collie, too.
								Pavel

-- 
68:        byte [] adUSER = GetAtomData( GetAtomPos( AtomUSER ), true );
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/