Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 May 2020 10:55:11 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Samuel Zou <zou_wei@huawei.com>
Cc:     jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com,
        joe.lawrence@redhat.com, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static
Message-ID: <20200508155511.462d6pnbebcryi2j@treble>
References: <1588939594-58255-1-git-send-email-zou_wei@huawei.com>
 <20200508155335.jyfo4rhdvbyoq5kl@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200508155335.jyfo4rhdvbyoq5kl@treble>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 08, 2020 at 10:53:41AM -0500, Josh Poimboeuf wrote:
> On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote:
> > Fix the following sparse warning:
> > 
> > kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs'
> > was not declared. Should it be static?
> 
> Yes, it should :-)
> 
> So instead of the question, the patch description should probably state
> that it should be static because its only caller is in the file.

... and it probably should also have a Fixes tag which references the
commit which introduced this issue.

> With that change:
> 
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh