Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 May 2020 18:17:01 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com,
        torvalds@linux-foundation.org, tglx@linutronix.de,
        mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org,
        ard.biesheuvel@linaro.org, pbonzini@redhat.com,
        mathieu.desnoyers@efficios.com
Subject: Re: [PATCH v4 14/18] static_call: Add static_cond_call()
Message-ID: <20200508161701.GD3344@hirez.programming.kicks-ass.net>
References: <20200501202849.647891881@infradead.org>
 <20200501202944.593400184@infradead.org>
 <20200506172455.ho5em2mtzn7qqfjl@treble>
 <20200508152730.GB3344@hirez.programming.kicks-ass.net>
 <20200508154704.6njw5wfsain7p3ev@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200508154704.6njw5wfsain7p3ev@treble>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 08, 2020 at 10:47:04AM -0500, Josh Poimboeuf wrote:

> And if you're calling it
> 
>   DEFINE_STATIC_CALL_NULL
> 
> then it seems like
> 
>   ARCH_DEFINE_STATIC_CALL_NULL
> 
> would be the logical name rather than RETTRAMP?

But that looses the TRAMP, and ARCH_DEFINE_STATIC_CALL_NULL_TRAMP so
damn long, then again, it's only 2 chars more than what I have now,
sure, lets do it.

> Still not crazy about static_cond_call(), though I think at least
> changing it to static_call_cond() would be better for namespacing
> reasons.

Done.