Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp217036ybj; Fri, 8 May 2020 10:04:44 -0700 (PDT) X-Google-Smtp-Source: APiQypKlk84NH/Klvh3k4t3+onrnNERkz6wruZehS0GopNfi95PPw61ewG2SyfhdkIDPI7VC9Grf X-Received: by 2002:a17:906:1443:: with SMTP id q3mr2777376ejc.325.1588957484320; Fri, 08 May 2020 10:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588957484; cv=none; d=google.com; s=arc-20160816; b=Y6rMRgfZhw9v4pVJXxia0+v26m4PYK9UC+HqXseAtkkr7+vNuhImDTN/CbJ5HJF6fU CLgqy2CaBzeSrM1Qin0XJ5d1bqbLHuLdZE1mr8wl44bgog1I8hWq+/jbq6myKX+Uy6Z1 8SPId4yvHN2ktvIOMd4DfmKtmkmd9qqShWMEU+gRhNDyE6Z4mF9+VVIdIzYuSeS/f/4b hrjxPkNY/SrYGHeChCSvMlVb/DZDYxlOHYzoyniOTosUduKwW9jERrnkA2ddcOEcdLu2 Rlx9doWW1LjFu2vEFcrnVelsB5MYAO6Sd8FsXVdOsFOOH6XWYnNnzp98i/CqPJ7C1EeT ACnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=dcJpg0FysVgftiU92EXiTO7WOwsgKp6NBzKm+wuQsF4=; b=F88P0rNkiXL2/IkAYyAvmW2YoSjxrIts3rMBtn1G6RXLyKKkdoApYiJJXydEE7KY4h fo3wECfm+iY0RRgaikbcQS5KWHxeoWYGuDdkErR07jctjElDMwdxC0YbGaopt4ksj8N/ drjbUdCE424NCsc5vwDwxqsH9O1/VSLcpG+4U/4RheZGkGNGyiuTxFXif1/oz8zelShY BEHq/CRWgTdUZLtRewJvQV6EX7bw9jFBsY+TET0v8eZfBSs056gkgMQ9fs2xRcRVFRH/ 0QG1fkVJ7tRehqWEjSZzVHqPipkBZ9tbN7rg/JqpfoynR1YPslhX6nyPuWHV4wQdsR/o IoVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=FAx0BodV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si1243276ejh.334.2020.05.08.10.04.10; Fri, 08 May 2020 10:04:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=FAx0BodV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726904AbgEHRAV (ORCPT + 99 others); Fri, 8 May 2020 13:00:21 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:17063 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726750AbgEHRAV (ORCPT ); Fri, 8 May 2020 13:00:21 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 08 May 2020 09:58:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 08 May 2020 10:00:20 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 08 May 2020 10:00:20 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 May 2020 17:00:19 +0000 Subject: Re: [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies To: Arnd Bergmann , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= CC: Jason Gunthorpe , Andrew Morton , Masahiro Yamada , Changbin Du , Randy Dunlap , Stephen Rothwell , Anshuman Khandual , Krzysztof Kozlowski , References: <20200508144017.3501418-1-arnd@arndb.de> From: Ralph Campbell X-Nvconfidentiality: public Message-ID: <913026fd-1911-55dd-823c-b11bce9b2f37@nvidia.com> Date: Fri, 8 May 2020 10:00:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200508144017.3501418-1-arnd@arndb.de> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1588957088; bh=dcJpg0FysVgftiU92EXiTO7WOwsgKp6NBzKm+wuQsF4=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FAx0BodVHFLUY+FSvDHpvTF4RYQhnYTdR1kdjbOeITRX+ugaZJXndi2IKn+d/Jysk IUJ4c+PiZhlshoubc2WXNM5socv5jYvZAy3um0JPMB7RU1f5/6jqx37a+Q2akmfpRQ /PLMXwHWoSKwYNzyuY9MFtJuRAE483kdpl71w72gKeoyoFbUAcwgEBzzbT1EMMTxyl rPXHJB8HVyjDGLjGsSU0UBQe1FBOoC4+wVlEo4XKkdOc5DHOkkETj3SeKllM6n9J/c 7+8PUI1DXgTXK44fwZUw2jOhJlcsGJTHvk8C0RJdi4V6IAHYq9nbpQetnyqszVQZNM qpx2e5CnbT7DQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/20 7:40 AM, Arnd Bergmann wrote: > One cannot select DEVICE_PRIVATE when its dependencies are disabled: > > WARNING: unmet direct dependencies detected for DEVICE_PRIVATE > Depends on [n]: ZONE_DEVICE [=n] > Selected by [m]: > - TEST_HMM [=m] && RUNTIME_TESTING_MENU [=y] && TRANSPARENT_HUGEPAGE [=y] > lib/test_hmm.c:480:8: error: implicit declaration of function 'memremap_pages' [-Werror,-Wimplicit-function-declaration] > ptr = memremap_pages(&devmem->pagemap, numa_node_id()); > ^ > lib/test_hmm.c:480:8: note: did you mean 'memcmp_pages'? > include/linux/mm.h:3082:12: note: 'memcmp_pages' declared here > extern int memcmp_pages(struct page *page1, struct page *page2); > ^ > lib/test_hmm.c:480:6: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Werror,-Wint-conversion] > ptr = memremap_pages(&devmem->pagemap, numa_node_id()); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > lib/test_hmm.c:1089:4: error: implicit declaration of function 'memunmap_pages' [-Werror,-Wimplicit-function-declaration] > memunmap_pages(&devmem->pagemap); > > Add a dependency from CONFIG_TEST_HMM to ZONE_DEVICE, to disallow > those broken configurations. Thanks for fixing this. > > Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM") > Signed-off-by: Arnd Bergmann Since the HMM tests are not yet in Linus' tree, shouldn't this patch just be folded into Jason's hmm tree instead of a Fixes: line? Reviewed-by: Ralph Campbell > --- > lib/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d9885fa37cc0..63667d62c9d8 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2262,6 +2262,7 @@ config TEST_MEMINIT > config TEST_HMM > tristate "Test HMM (Heterogeneous Memory Management)" > depends on TRANSPARENT_HUGEPAGE > + depends on ZONE_DEVICE > select DEVICE_PRIVATE > select HMM_MIRROR > select MMU_NOTIFIER >