Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1588958976.5146.83.camel@linux.ibm.com>
Subject: Re: [PATCH v4 1/7] ima: Switch to ima_hash_algo for boot aggregate
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Jerry Snitselaar <jsnitsel@redhat.com>
Cc:     Roberto Sassu <roberto.sassu@huawei.com>,
        James.Bottomley@hansenpartnership.com,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com,
        stable@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>,
        Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Date:   Fri, 08 May 2020 13:29:36 -0400
In-Reply-To: <20200508045410.t7gawyklyecupe2u@cantor>
References: <20200325104712.25694-1-roberto.sassu@huawei.com>
         <20200325104712.25694-2-roberto.sassu@huawei.com>
         <1585871617.7311.5.camel@linux.ibm.com>
         <20200508045410.t7gawyklyecupe2u@cantor>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 21:54 -0700, Jerry Snitselaar wrote:
> On Thu Apr 02 20, Mimi Zohar wrote:
> >Hi Roberto,
> >
> >On Wed, 2020-03-25 at 11:47 +0100, Roberto Sassu wrote:
> >> boot_aggregate is the first entry of IMA measurement list. Its purpose is
> >> to link pre-boot measurements to IMA measurements. As IMA was designed to
> >> work with a TPM 1.2, the SHA1 PCR bank was always selected even if a
> >> TPM 2.0 with support for stronger hash algorithms is available.
> >>
> >> This patch first tries to find a PCR bank with the IMA default hash
> >> algorithm. If it does not find it, it selects the SHA256 PCR bank for
> >> TPM 2.0 and SHA1 for TPM 1.2. Ultimately, it selects SHA1 also for TPM 2.0
> >> if the SHA256 PCR bank is not found.
> >>
> >> If none of the PCR banks above can be found, boot_aggregate file digest is
> >> filled with zeros, as for TPM bypass, making it impossible to perform a
> >> remote attestation of the system.
> >>
> >> Cc: stable@vger.kernel.org # 5.1.x
> >> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with PCR read")
> >> Reported-by: Jerry Snitselaar <jsnitsel@redhat.com>
> >> Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> >> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> >
> >Thank you!  This patch set is now queued in next-integrity-testing
> >during the open window.  Jerry, I assume this works for you.  Could we
> >get your tag?
> >
> 
> Yes, I no longer get the errors with this patch.
> 
> 
> Tested-by: Jerry Snitselaar <jsnitsel@redhat.com>

Thanks, Jerry.  I really do appreciate receiving your tag.

Not all, but a lot of subsystems, do not rebase their branch, at least
once it is in linux-next.  Adding tags is considered rebasing.  For
this reason, I've started staging patches in the next-integrity-
testing branch, before moving them to next-integrity.

thanks,

Mimi