Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp259614ybj; Fri, 8 May 2020 11:07:39 -0700 (PDT) X-Google-Smtp-Source: APiQypIRIaCj7T6v34Jp550Q3kDHu/H+JhtVh24qzPUIwtev24zSWZWBJI2y4KouYji2O4vXVvaN X-Received: by 2002:a17:907:262b:: with SMTP id aq11mr2969633ejc.277.1588961259525; Fri, 08 May 2020 11:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588961259; cv=none; d=google.com; s=arc-20160816; b=FGfXbLCzNm8y0fYx/jPCbFy/0ejJybPOGzLzfi9xg9K3LiBs0c7XGTttRiJdx7Vcol YusbIImQGz6qz7kVNFIUnGQXopgd/npdlHfvyvt74UXBvOZjyBMbrkeaizNcMwiSeOrK /NfPlkj4C1cXVcpejhz2Z1SLv+a/4LtShVqO0fZMilvci1lqt9ysuUbmGsIxVjz36IdM wX3hmyHSnn+qUrtKJecP9lTzOCx7DDUtUYk5VlblMi7BcF6tHJ89vO/b42u7yfWKSnGi B5QLqQmE8DEbmxzofHtXK7Ldq6Z+zUprJO+Cd1KFh6XXYDlXDU5pOl+Z2M7C4LulRm4/ FbDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=c+rS9T3Fi+HZ259PJiMCiEWW0nbNynX2/eYoPG8f92o=; b=OPYRg3Fed7Fpdi/pDcE3lpzBJiTqKo0g1eJFLt7/RnYSk0NhAjWmXIiwIMX4FSSW8a L7ds8AsneXxhidF1ZgBXuf8VGILcKqD59Bivgpym/8hcRH1S32OxqJJJE+R+eqdSyhiA R2fh/kfKeHndt95Cr5cUB9D8qzMnQYmHrcJ842BQi8mnp8NgQ1R1VDkLia8m7Nu2VhtK gmaYgjP6V1iGqrblO8W+/Q7xfLnWcq088SckdSqfs3rSVpYZBxq0TxeYQJDR/MrFsBHA SnE52ECtlCcZO39oAvq1/54Gzfs3jZHUk73By+61/MzDsMD46GZyQ1K5O1u0ZEgmJc6a 6rJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=chkI37xl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si1465754ede.225.2020.05.08.11.07.16; Fri, 08 May 2020 11:07:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=chkI37xl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbgEHSCj (ORCPT + 99 others); Fri, 8 May 2020 14:02:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:47996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbgEHSCd (ORCPT ); Fri, 8 May 2020 14:02:33 -0400 Received: from e123331-lin.nice.arm.com (amontpellier-657-1-18-247.w109-210.abo.wanadoo.fr [109.210.65.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A833F24957; Fri, 8 May 2020 18:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588960952; bh=NXgOr8+IDDJ86JzwJlupV+Xks7Oz1oRGnMkA9Se54V0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=chkI37xlMKjCwq9IVeoRBZlXmxOvdEHVCnMZ6tvXyXMjvAPUkOiwbTf9A8MAqpAQJ 8jMQPfk0NtJCL40bsAoyK6emepc7g7pMvvKy72YdtUfuVeSCMgro3xghsupLUqj3yU PteWy90qjB3hrVrZEGW8wi40UKrktVd9CRFiDo+Q= From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Arnd Bergmann , Arvind Sankar , Guenter Roeck , Joe Perches Subject: [PATCH 05/15] efi/gop: Use efi_err for error messages Date: Fri, 8 May 2020 20:01:47 +0200 Message-Id: <20200508180157.1816-6-ardb@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508180157.1816-1-ardb@kernel.org> References: <20200508180157.1816-1-ardb@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arvind Sankar Use efi_err instead of bare efi_printk for error messages. Signed-off-by: Arvind Sankar Link: https://lore.kernel.org/r/20200430182843.2510180-6-nivedita@alum.mit.edu Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/libstub/gop.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efi/libstub/gop.c b/drivers/firmware/efi/libstub/gop.c index 64cee0febae0..34c0cba2c8bf 100644 --- a/drivers/firmware/efi/libstub/gop.c +++ b/drivers/firmware/efi/libstub/gop.c @@ -134,14 +134,14 @@ static u32 choose_mode_modenum(efi_graphics_output_protocol_t *gop) max_mode = efi_table_attr(mode, max_mode); if (cmdline.mode >= max_mode) { - efi_printk("Requested mode is invalid\n"); + efi_err("Requested mode is invalid\n"); return cur_mode; } status = efi_call_proto(gop, query_mode, cmdline.mode, &info_size, &info); if (status != EFI_SUCCESS) { - efi_printk("Couldn't get mode information\n"); + efi_err("Couldn't get mode information\n"); return cur_mode; } @@ -150,7 +150,7 @@ static u32 choose_mode_modenum(efi_graphics_output_protocol_t *gop) efi_bs_call(free_pool, info); if (pf == PIXEL_BLT_ONLY || pf >= PIXEL_FORMAT_MAX) { - efi_printk("Invalid PixelFormat\n"); + efi_err("Invalid PixelFormat\n"); return cur_mode; } @@ -222,7 +222,7 @@ static u32 choose_mode_res(efi_graphics_output_protocol_t *gop) return m; } - efi_printk("Couldn't find requested mode\n"); + efi_err("Couldn't find requested mode\n"); return cur_mode; } @@ -316,7 +316,7 @@ static void set_mode(efi_graphics_output_protocol_t *gop) return; if (efi_call_proto(gop, set_mode, new_mode) != EFI_SUCCESS) - efi_printk("Failed to set requested mode\n"); + efi_err("Failed to set requested mode\n"); } static void find_bits(u32 mask, u8 *pos, u8 *size) -- 2.17.1