Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3720ybk; Fri, 8 May 2020 12:28:59 -0700 (PDT) X-Google-Smtp-Source: APiQypKHDf6O1VpclwwRjs6dQKruH+Lw6UvufqtY+oQODhZG/f2piL2duregVYDdT75m1thIiPIL X-Received: by 2002:a17:906:17c5:: with SMTP id u5mr3280536eje.275.1588966139058; Fri, 08 May 2020 12:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588966139; cv=none; d=google.com; s=arc-20160816; b=Fc2KGXqMmBrsoBCvIglDrgp4n31+BzlJD61+kQExwYdtmNXEbbQe+LMkAJHMElS5rt k6UGnL4/kJB5LRxg/bOlMWVhjrqFS/wxU+0Lbr2N10Mzf5LXhEmySfBwSciFZ35wzgdc /r9TouCZnuirOVOSRnkkhco6N0OQgMnrEZdPvbm+CppQmkPXUtGsmKBrzRU0NaNaauRA r58G1oNXPGTBlcqYySwpVQIkHImopHfk74/YbfjCBb1ClBaPfLoWKE5VRF8hM602Ly4j zCmNWDPIr6sMBoJ3JpYq3MPi+z4PxDzxlX6TDrXc81ZIFXXGuAN7eQqAnk7jNn9HUciw RTNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/n+fvL0Hbascibzpzvsagyy3/Tu/+2iBSS9bDVKIOT4=; b=vgO8dSYaSY6w2RegmI/bqsBibggp0MFt2Kj1ldWiK/RHvuTWqTYQrr9NPYfp5RlNCr sIsnjvknC20VbkBxRMIZH5csTbgPAYxuVYBs7Qwx1alKO64Tu8vEH6XsfDJabfb0Th8D w0O6CbaWO2tXWGr3ZI+SnQsv54nvLSHs0kL+DJ4vZGpDYUo+Hi+IuFpR3UwY/PzZsOyM xrnWDG9s/KYtP4pp+5xag1eCvzdiGECjxxh1ARm+nISbbJbao5l0Bsv3GV1byIWPm87L 30w9H3/y09InzKX1Lx6wXWRJ/O2vZOGvlPi6kzCSLIJBY+3e3SGZ85CFtRxtjMm37LwI vi1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fDj+DMEi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si1517319edv.549.2020.05.08.12.28.35; Fri, 08 May 2020 12:28:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fDj+DMEi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727051AbgEHT1N (ORCPT + 99 others); Fri, 8 May 2020 15:27:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:46508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbgEHT1N (ORCPT ); Fri, 8 May 2020 15:27:13 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E095D20CC7; Fri, 8 May 2020 19:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588966033; bh=VhqAKcrwPY0cVjT8gdoCJ7J8gaWXKFNI6YLceVclDoY=; h=From:To:Cc:Subject:Date:From; b=fDj+DMEi/SmQgVWwDwS7YLee4L0T/31dur7XaM2FBscsNSoBZLyJ88HhASvA1cepz Bz8CQcGx+XeWTP6pjoPqcHhpIIzs5e/m5G5yZhombwWCdSy7pzfH4uJFDvzHDvaDDp nNFUwe47loM8tgvp8WqkChYCEg+e/zf5mXIQCJ4Y= From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Jaegeuk Kim Subject: [PATCH] f2fs: remove blk_plugging in block_operations Date: Fri, 8 May 2020 12:27:11 -0700 Message-Id: <20200508192711.146175-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org blk_plugging doesn't seem to give any benefit. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 97b6378554b40..cc9dd3bbf2188 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -1169,8 +1169,6 @@ static int block_operations(struct f2fs_sb_info *sbi) struct blk_plug plug; int err = 0, cnt = 0; - blk_start_plug(&plug); - retry_flush_quotas: f2fs_lock_all(sbi); if (__need_flush_quota(sbi)) { @@ -1198,7 +1196,7 @@ static int block_operations(struct f2fs_sb_info *sbi) f2fs_unlock_all(sbi); err = f2fs_sync_dirty_inodes(sbi, DIR_INODE); if (err) - goto out; + return err; cond_resched(); goto retry_flush_quotas; } @@ -1214,7 +1212,7 @@ static int block_operations(struct f2fs_sb_info *sbi) f2fs_unlock_all(sbi); err = f2fs_sync_inode_meta(sbi); if (err) - goto out; + return err; cond_resched(); goto retry_flush_quotas; } @@ -1229,7 +1227,7 @@ static int block_operations(struct f2fs_sb_info *sbi) err = f2fs_sync_node_pages(sbi, &wbc, false, FS_CP_NODE_IO); atomic_dec(&sbi->wb_sync_req[NODE]); if (err) - goto out; + return err; cond_resched(); goto retry_flush_quotas; } @@ -1240,8 +1238,6 @@ static int block_operations(struct f2fs_sb_info *sbi) */ __prepare_cp_block(sbi); up_write(&sbi->node_change); -out: - blk_finish_plug(&plug); return err; } -- 2.26.2.645.ge9eca65c58-goog