Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200507173408.20754-5-alcooperx@gmail.com> <Pine.LNX.4.44L0.2005081444450.11470-100000@netrider.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.2005081444450.11470-100000@netrider.rowland.org>
From:   Alan Cooper <alcooperx@gmail.com>
Date:   Fri, 8 May 2020 16:32:39 -0400
Message-ID: <CAOGqxeVmvJxqXEqymuCJRXqLH9O70Lc7GLTBdfYt_zpB6jexyA@mail.gmail.com>
Subject: Re: [PATCH v7 4/5] usb: ehci: Add new EHCI driver for Broadcom STB SoC's
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     ": Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        DTML <devicetree@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 8, 2020 at 2:46 PM Alan Stern <stern@rowland.harvard.edu> wrote:
>
> On Thu, 7 May 2020, Al Cooper wrote:
>
> > Add a new EHCI driver for Broadcom STB SoC's. A new EHCI driver
> > was created instead of adding support to the existing ehci platform
> > driver because of the code required to workaround bugs in the EHCI
> > controller. The primary workround is for a bug where the Core
> > violates the SOF interval between the first two SOFs transmitted after
> > resume. This only happens if the resume occurs near the end of a
> > microframe. The fix is to intercept the echi-hcd request to complete
> > RESUME and align it to the start of the next microframe.
> >
> > Signed-off-by: Al Cooper <alcooperx@gmail.com>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Adding a new EHCI platform-specific driver is okay with me.  However,
> this patch does not include most of the changes you discussed with
> Greg.  I assume you will submit a revised version with those changes in
> place; when you do I will Ack it.
>
> Alan Stern
>

I mistakenly sent a partially fixed version instead of the version
with all the fixes (git stashed). I'm sending v8 will all the fixes.

Thanks


Thanks
Al