Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 8 May 2020 23:46:50 +0200
From:   Helge Deller <deller@gmx.de>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     "James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
        Helge Deller <deller@gmx.de>, linux-parisc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: suppress error messages for 'make clean'
Message-ID: <20200508214650.GA3482@ls3530.fritz.box>
References: <20200425054659.814774-1-masahiroy@kernel.org>
 <CAK7LNAQk_fLFCWuFCC0NK3nxVE0bs-n7E+T-dbn14aCZVg_pgQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAQk_fLFCWuFCC0NK3nxVE0bs-n7E+T-dbn14aCZVg_pgQ@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Masahiro Yamada <masahiroy@kernel.org>:
> On Sat, Apr 25, 2020 at 2:47 PM Masahiro Yamada <masahiroy@kernel.org> w=
rote:
> >
> > 'make ARCH=3Dparisc clean' emits a tons of error messages as follows:
> >
> >   $ make ARCH=3Dparisc clean
> >   gcc: error: unrecognized command line option '-mno-space-regs'
> >   gcc: error: unrecognized command line option '-mfast-indirect-calls'=
; did you mean '-mforce-indirect-call'?
> >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> >   gcc: error: unrecognized command line option '-mno-space-regs'
> >   gcc: error: unrecognized command line option '-mfast-indirect-calls'=
; did you mean '-mforce-indirect-call'?
> >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> >     ...
> >
> > You can supporess them except '-Wframe-larger-than' by setting correct
> > CROSS_COMPILE=3D, but we should not require any compiler for cleaning.
> >
> > This $(shell ...) is evaluated so many times because LIBGCC is exporte=
d.
> > Use the ':=3D' operator to evaluate it just once, and sink the stderr.
> >
>
> Applied to linux-kbuild.

That patch breaks then building the boot loader/compressor:
...
  hppa-linux-gnu-ld    -X -e startup --as-needed -T arch/parisc/boot/compr=
essed/vmlinux.lds arch/parisc/boot/compressed/head.o arch/parisc/boot/comp=
ressed/real2.o arch/parisc/boot/compressed/firmware.o arch/parisc/boot/com=
pressed/misc.o arch/parisc/boot/compressed/piggy.o -o arch/parisc/boot/com=
pressed/vmlinux
hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `dec_vl=
i':
(.text+0x104): undefined reference to `__ashldi3'
hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `lzma_l=
en':
(.text+0x2b0): undefined reference to `$$mulI'
hppa-linux-gnu-ld: (.text+0x344): undefined reference to `$$mulI'
hppa-linux-gnu-ld: (.text+0x3f8): undefined reference to `$$mulI'


The patch below works, but I wonder if it's possible to avoid
to examine LIBGCC twice....?

Helge


diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 628cd8bb7ad8..aeea20abbf01 100644
=2D-- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -21,8 +21,7 @@ KBUILD_IMAGE :=3D vmlinuz

 NM		=3D sh $(srctree)/arch/parisc/nm
 CHECKFLAGS	+=3D -D__hppa__=3D1
-LIBGCC		=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
-export LIBGCC
+LIBGCC		:=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)

 ifdef CONFIG_64BIT
 UTS_MACHINE	:=3D parisc64
diff --git a/arch/parisc/boot/compressed/Makefile b/arch/parisc/boot/compr=
essed/Makefile
index 1e5879c6a752..b008cf1b5c1e 100644
=2D-- a/arch/parisc/boot/compressed/Makefile
+++ b/arch/parisc/boot/compressed/Makefile
@@ -22,6 +22,8 @@ ifndef CONFIG_64BIT
 KBUILD_CFLAGS +=3D -mfast-indirect-calls
 endif

+LIBGCC  :=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
+
 OBJECTS +=3D $(obj)/head.o $(obj)/real2.o $(obj)/firmware.o $(obj)/misc.o=
 $(obj)/piggy.o

 LDFLAGS_vmlinux :=3D -X -e startup --as-needed -T