Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp91948ybk; Fri, 8 May 2020 14:57:03 -0700 (PDT) X-Google-Smtp-Source: APiQypLRXoh6phxFLOhwQGuOvWAp0x/sDWOGtCIQVHPaz6jIA6YRsrvNMR8IsIfqY160gSJ5bMYR X-Received: by 2002:a05:6402:8c9:: with SMTP id d9mr3940141edz.357.1588975023278; Fri, 08 May 2020 14:57:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588975023; cv=none; d=google.com; s=arc-20160816; b=hirv96S9Utm0O19OLsqTuSoQFg3VyLGWNYrZMpMommhEFj72qzRBVzjukJO6eVDONP fOBwKKtrNvfvphCFXwzQOuNMU6kbZgohtWuYpmKC5rRjJRGkXcERQDKXpc4J+mQXamq+ d7vvdaMaEzPV+4g7kibCZ1dhY1yPjBYWOKLpdq9SSXo301CMQG/N2l28ROxhN3i9MzIm Ol4mF+ISC25KstLim/pLfk+Syq7g1wCA+1Fyt/dyF8mMFFovOzGNfsnW2VCQz8p0IKEh wxXsKxcawVXsY7vCJDUD1kBpquRfuvKMRqBdDaQx2fXikNenK0MB6L6d3aHYIJyRUEy3 ubnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/Bg23MpwaLt5ES1Q90+CSXO9u0G+8VEy9TthqACk8pE=; b=eKJiFg69yranjsdM3pQKdi/UD5rlb2fvtROMTB3te2nIOBTkd2abG0sX6H9DtY8gap fzYEG5b+YLGBCJ3svxaPfgtls3oBGlQ5oqxeMFICjs7MbXugEXh/Cur9kC1cgF1VUgti HhbwSCYipWgP4JFURG3xBazQOM4pfcthiZrllHnGWOluflOJbOcaKtdUdHwpFwAbGvpN MOyAKr6ZYskBdZgEut0xpMAmh1HFNzWJTkpKsaFsJvlnCjsb68jys189LiTOpmdiOkqo sxnymG4qavXzo0ZgnJDnIxvKKOCfHKq86AisNlD9iQEPOOPR75AIvTwrj41r6cSib1qQ xxAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=1rm4qMVb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l24si1735398ejc.451.2020.05.08.14.56.39; Fri, 08 May 2020 14:57:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=1rm4qMVb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727982AbgEHVwr (ORCPT + 99 others); Fri, 8 May 2020 17:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgEHVwq (ORCPT ); Fri, 8 May 2020 17:52:46 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4727BC061A0C for ; Fri, 8 May 2020 14:52:46 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id fb4so1384786qvb.7 for ; Fri, 08 May 2020 14:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/Bg23MpwaLt5ES1Q90+CSXO9u0G+8VEy9TthqACk8pE=; b=1rm4qMVbcyKhgRbqDol38rBrkbyaZbxpfkXsQfwESaWUofm9FQVmK/wxaUfeIUZygo HsGYt09Ll+D1Q0/NDvGuVng7N+gAh0575gb8z6n8u+dxMoQHoC1vfOYVhf68hgZoLvhb LvTWV94B9ObgkjWuVKW+yxNPICHdMTrcOc92uPtwZpCy5PSiU0iklgWmIEx1+ny+Lmdp r8n9oZQHT856fp9eRfvxZU5UPwlEyFophlObXiv3bFFtElwVs1Cw9q3D149s40LMK8a/ ZWmePp2TvUuF/ICL2KJQ7+1+jY2pq+wlkDiMsN/8bp0c8W/1W2ZxCweHg7a/K6x7WB9D NnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/Bg23MpwaLt5ES1Q90+CSXO9u0G+8VEy9TthqACk8pE=; b=q9RvQtBRReAioCnJ0y+//CzfeA+zL7i+nzO0Q9HS2BYYdvbZN4nNYQp1xt8aQ0h0gG nI9mWD1z7n4A70ZIAf3K5fezuEL+PpYfUZ3LPcY/Po2DkLiYo/zzFGXFfKhIZbAdQjch 186U7E1+9yojGgmOY26SHx1DBaBrSXtTuUrKtMPYiHdKiIoCp6FDMzuMjD0dD9uRAjsa kzWc9g9eE7NrlFx20aGKVnEfLZIXMI8OHszvz4tvlK8cTObmf9iQNj8bt8PJQGLHDIhj rTPiseZV+wY3vRYnkARwkeUYtlXcB4tWCElcRhgDkZ2a+rtbuycS31Yz36B+UJloDgYJ MAmQ== X-Gm-Message-State: AGi0PuYinHdDkWpdOYspjrO53qAGpx1qJO3xB7S/zY/Zkp2Q+GEmelva 4XK37jH3LlJls70R66sOi7WZqQ== X-Received: by 2002:a0c:f8c4:: with SMTP id h4mr4924155qvo.15.1588974765599; Fri, 08 May 2020 14:52:45 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2627]) by smtp.gmail.com with ESMTPSA id m7sm2547075qti.6.2020.05.08.14.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:52:45 -0700 (PDT) Date: Fri, 8 May 2020 17:52:28 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Yafang Shao , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: swap: fix vmstats for huge pages Message-ID: <20200508215228.GC226164@cmpxchg.org> References: <20200508212215.181307-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508212215.181307-1-shakeelb@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 02:22:13PM -0700, Shakeel Butt wrote: > Many of the callbacks called by pagevec_lru_move_fn() do not correctly > update the vmstats for huge pages. Fix that. Also __pagevec_lru_add_fn() > use the irq-unsafe alternative to update the stat as the irqs are > already disabled. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner