Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp92844ybk; Fri, 8 May 2020 14:58:48 -0700 (PDT) X-Google-Smtp-Source: APiQypKz28NBDSNUa50I/tsOw4D5ttzyZv3/B1CqMgnOBAXlVv7iL+3v/OlTg397iAMI0QDriK6M X-Received: by 2002:a17:906:85d3:: with SMTP id i19mr3646665ejy.153.1588975128075; Fri, 08 May 2020 14:58:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588975128; cv=none; d=google.com; s=arc-20160816; b=kKE6cHiTEZjrSOoBknJX0jeEt2zKdxfDhCC9fSbNZZS1KAS4ernLAC0qG9SRpr9HOh 388b2Agq/RvA4riMCp/e8wXVK8nK5AvzTLBNGJR5axEp3g3I55q0Hm8vUA66AewshBp8 /WzBP8UVveZrhL970hNGdZwOpzgRv7TNlRmNZv7Iqqqm4gfMC0UBZCofQicWkZcUFfYE gjzvYSkdobsG2Us2H9pfJqHTH3FRu7NWNqAlaTKk3fHTh0nFDTe4xWOBbkusScwEkbBT wXFSFXlK5YIVBsi8krQAD/ZrCUPccsA03Wx6T4qhnSZOeg69JrWT//v3zcOrBn5SZEti IZuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8zne5kD9U815Qp7lQoOfSkfWPnKdq4UH7l4ACZ1laQI=; b=drrDYM/WLg3jJg0jdDCjVtBI6emgaXT/27AJjDzz5oekd4/Vw63FwypOAW9Q+Z/9R1 TCS30Bf2cOAA9n576UagvRFormOwr1Qp8+NKVvddAItleprVoZNqWlknNpLCHxLFNnnA KgLYPIW8smCNDaHbrzNX0i+atAWsVjVGeQH4PYcXRk8T2uJXiUR8Ni6/9wPlQHgp26wv hF0u57CWnKd0fFZVoIPBPXvsQjFbB2f+WrDfDUblpziiARPorm7AdLnQda+rZ44T8kz0 SNfLxUAiQd6kqu+FY6iXcXYC+lVpJY23GSseka/6wtHRC8GV21bMLXJHkI8AiQU+1cdu AYaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=rVWxHIzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si1866637edr.148.2020.05.08.14.58.19; Fri, 08 May 2020 14:58:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=rVWxHIzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbgEHV4e (ORCPT + 99 others); Fri, 8 May 2020 17:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727828AbgEHV4e (ORCPT ); Fri, 8 May 2020 17:56:34 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03985C061A0C for ; Fri, 8 May 2020 14:56:34 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id s186so1545083qkd.4 for ; Fri, 08 May 2020 14:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8zne5kD9U815Qp7lQoOfSkfWPnKdq4UH7l4ACZ1laQI=; b=rVWxHIzDFvif9rrgKfKEzuzUqpug84jgH+pn6g2K+if7ys4WCpoBTPfsO3vQPvKAhN yVfFa2Lp+fBa+5PTkzDejJhE9e4mKzNB4oFie8Fb4O99NmTGN8QvA+xTxmSSZnk3ibBc HY2i6VFZUdjANcY0MDN1d4b9v0m8v8op+VhiOv7vwRUaW0FVadyL0QI7pMaOVKtzkkDK eICt41IJctDdTY3MUPL17fid7XHKjjKefy0raEReMlnpRuJoXM9b+XyKVFxobwnSPF9F Mh/uSrnjUReBhhaHgRTzE7vs/YNfmZ2ip7aKqPqWJrOr4nWGMCvhk2K4BK7cIVcztiM7 Ocsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8zne5kD9U815Qp7lQoOfSkfWPnKdq4UH7l4ACZ1laQI=; b=Rho6/H7Sd+LSlp0LhcJ1Wl0LEZXkuu4O4KTVLO6s3rp93aBEcJ1HuZA9D2lSumKBFY iHqVax2iHa73R57dwMEpMKP/rhH3uHWzFKrF1Uo6hQv8SPYoPrEgpaQXANorocnOWhuI RDUVF6CdqFyltuI8igUNix0dJA3VVRCgTLOvHCeefuGb4zbC3HzkPJV69QEHLcmyyrsK rz1b+XFxbgnRdS1Tuw1vDgB6g4oJtC76KNS4h/DWL39Hs9IZV5LvuxTR/nIF2XQwAfvn DJ6RCON+yvd3P7f19rWn9gLzJw9P08jFcWReBKmjb57CVTIkwBG70PE5lRAVItvNJkqZ 9PsQ== X-Gm-Message-State: AGi0Pub6O/OQ5ZrHTUT26wjgKY2x7PwWxPq6b5rVFaV9Yc8SM2r8gCIS DkqN/HcgLMlUGhRPzqnpu6f2Bg== X-Received: by 2002:a37:ac08:: with SMTP id e8mr4618592qkm.439.1588974993311; Fri, 08 May 2020 14:56:33 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:2627]) by smtp.gmail.com with ESMTPSA id x8sm2438260qti.51.2020.05.08.14.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:56:32 -0700 (PDT) Date: Fri, 8 May 2020 17:56:16 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Yafang Shao , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: swap: memcg: fix memcg stats for huge pages Message-ID: <20200508215616.GD226164@cmpxchg.org> References: <20200508212215.181307-1-shakeelb@google.com> <20200508212215.181307-2-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508212215.181307-2-shakeelb@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 02:22:14PM -0700, Shakeel Butt wrote: > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added > PGLAZYFREE, PGACTIVATE & PGDEACTIVATE stats for cgroups but missed > couple of places and PGLAZYFREE missed huge page handling. Fix that. > Also for PGLAZYFREE use the irq-unsafe function to update as the irq is > already disabled. > > Fixes: 2262185c5b28 ("mm: per-cgroup memory reclaim stats") > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner