Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp97080ybk; Fri, 8 May 2020 15:04:46 -0700 (PDT) X-Google-Smtp-Source: APiQypJE8/QHODKwXqgQFRKHGXxolpn34sotIKqVNmBmMqsTJWj14ihcX8RUamiiAVtZXClRr7M+ X-Received: by 2002:a05:6402:75a:: with SMTP id p26mr4018683edy.311.1588975486414; Fri, 08 May 2020 15:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588975486; cv=none; d=google.com; s=arc-20160816; b=XpUNviYPhPOHhd/dhymJM/TNqb4yV/9c5D9KON6OAHzPEWhh+YtD+ET4RPAdMv/9yZ NvyNRuLFhqKtEMTwv3j89mGixdaHWM5X6/lWX6unzkhXKBFO7gAWEFRN8naFtKeJJRLv mjDKcR/0xWL9q0pQ0L5GcGvqqytiia4p9SDGzcH68d5d8jTOMD++Y2b2ZvxRPYgHdCh/ q78ilcS5006LG+hTODTTMnwEJUURpE9XwsJBln2QgaxuL0YEkzhnF3YLk892NqS1dvKP +Q3teM9bdrMEwJlSbhOtkc2jK6HkCvmyXSgN0Nh+VSdEoKrZ1lmKHAkf5HpT9nComsiF pCgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=eivkrbmJzLZT+qQkoMBsXiu2QUlo8fpJDE1D1bvAt/I=; b=dfNeRG53sM9T6EhwAzc8+PJenPO1rq8HwsuMfgC5zaoPX5mkasOQiKBj03dMrUL2y9 VQe36YkJepnCM7RhqCDFIHkOyzKD9J3Q7fIYmpTSeRy/1Yptu3IH/vk9blQqP9BrhuL3 AeLQe73alJW2PLzzjgRHwHLEWIpS1+y2+h4YCA45FH3bdBkRo/krET+SplJLTQQO6Y2S 5mvb+3pAvyGcZf1W5kvKCZP0J1TWGgAHpOfj5BBkNz8GD0EHyUpi6mM4xq7bN0iqTe8f iqazi/nfWM1r8AwB7sfg/1cXRRPh9wiCStYAZPZzWBRJ4XHpYv50fM/S9AhNMnlPcbu0 rVHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si1774259edz.214.2020.05.08.15.04.21; Fri, 08 May 2020 15:04:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728053AbgEHWCw (ORCPT + 99 others); Fri, 8 May 2020 18:02:52 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:34557 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728032AbgEHWCw (ORCPT ); Fri, 8 May 2020 18:02:52 -0400 Received: from localhost.localdomain ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1Ma1oK-1jaQAZ0hW8-00W11D; Sat, 09 May 2020 00:02:27 +0200 From: Arnd Bergmann To: Joerg Roedel Cc: Arnd Bergmann , Joerg Roedel , Geert Uytterhoeven , Yoshihiro Shimoda , Will Deacon , Simon Horman , Robin Murphy , Hai Nguyen Pham , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] iommu/renesas: fix unused-function warning Date: Sat, 9 May 2020 00:02:16 +0200 Message-Id: <20200508220224.688985-1-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:nguKpoyDbwtn9OPppaa1Wkm4f1dh24v77iIkSuLPsDpqTEETLOi 8fGI9X9HbB6Af8+GtEuUXekkCnA0zjffrQYJhHl/OPgS7W0gkuT+/ZASHGVNNBmD3SfMcH1 AAGLAMgVzsl7553S0p0+gRRp9X/+7V2PRZdlyEWbVSJ2rM1gHU0VKGWC/NrJKqt0rHiFIR0 9FR0/q2tCmYqKwfxA3KEQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:WGPHeoCJUXo=:PqfGjNxO7ONTBOkQt/zAOC QlMKZK0qcyOf3cdLRylgomWSUGUDNkcqfUM36WbBmvEoCzkvl4tr+BDAKe3jP7p18JxptopLs UFBYh+LgN7pY9RduTraN7x5nTpgkQf9C7A1MgDARF1JLR5f5N3SgY0v+EQqfHws6zHKvJMelL DwMo4oSCL+3M16cmQbmdraaCkOrVkJQ5gF34CO2ZzhRL7MHYHR1Iy1XIanAzGqyMbMKKuoDVR PlEKq1suHKxI/ATEie3dGznx1dEKJXxaPyvxEMf0Db5oldNDTMEX/WA6BYJ8dgUaw+b9j+aA7 rEzTVjUnU6TDC9nmS+fWwabEaSuHLjMKWXeb5+emVhbQUyXXqv9d9L+r03km42Z7gsjfmPk6L kfESyxiLlnzSg8v9otXEYCsilsULpMPkbDGzmd5qkOdKt791iMo4VfYkuh7wqVsnjWEC+f3u+ ow2BEzyCLe7JJvjuYy5ZbcP536WJ5f+sdjqgC7N9V0tk7nLCUcz9nbRuvx+Pt/AIJYOVwARoE Q249S44z3FYo0mCcrc2KtbBUqyNfidv0Vs0+maeykj9XySk/50QkEMeBbnyxkMgZr6efRHcLM mw/jeVZ9Lb3SJTfUszsp3y5+gzynRf1eQ2K2G5/d0qpVqiBudB/es/RMEY70VkyogwNIiohyJ P+icQj54FV47lv1EYva3zM/poh54vDXE31mCyN9HZRCujg9TnNtQrNGJoNV6OBQpX9LL4tARj sMMZ+qrS+jXKNKjD+eKroIiBhuCr74S0ycznjIn0tx/hAHkIKysvkzgqBZQorv2Gqgslt+Pis s2dgqRHg8mK402ZMbvmx3vt0xB3AStgNO3joc6teXckSiZ8M0o= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns because the only reference to ipmmu_find_group is inside of an #ifdef: drivers/iommu/ipmmu-vmsa.c:878:28: error: 'ipmmu_find_group' defined but not used [-Werror=unused-function] Change the #ifdef to an equivalent IS_ENABLED(). Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device() call-backs") Signed-off-by: Arnd Bergmann --- drivers/iommu/ipmmu-vmsa.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index fb7e702dee23..4c2972f3153b 100644 --- a/drivers/iommu/ipmmu-vmsa.c +++ b/drivers/iommu/ipmmu-vmsa.c @@ -903,11 +903,8 @@ static const struct iommu_ops ipmmu_ops = { .probe_device = ipmmu_probe_device, .release_device = ipmmu_release_device, .probe_finalize = ipmmu_probe_finalize, -#if defined(CONFIG_ARM) && !defined(CONFIG_IOMMU_DMA) - .device_group = generic_device_group, -#else - .device_group = ipmmu_find_group, -#endif + .device_group = IS_ENABLED(CONFIG_ARM) && !IS_ENABLED(CONFIG_IOMMU_DMA) + ? generic_device_group : ipmmu_find_group, .pgsize_bitmap = SZ_1G | SZ_2M | SZ_4K, .of_xlate = ipmmu_of_xlate, }; -- 2.26.0