Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp6337ybk; Fri, 8 May 2020 16:48:53 -0700 (PDT) X-Google-Smtp-Source: APiQypLpmtrXLg2A4ZRa632XsUSzu9VVfFXksVJkzHpASy5EyLIcvfSDQOrpptziB7LbmmwCQvko X-Received: by 2002:a17:906:edc2:: with SMTP id sb2mr3779784ejb.129.1588981733217; Fri, 08 May 2020 16:48:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588981733; cv=none; d=google.com; s=arc-20160816; b=npe/ZTEbhAujBABJWwcf2VsH/FXmP/UE+4on8/dvwad0m1qdOU3R51Ymt2uwEHZdVb uhM2KxOX/AL75Cpkvd1bKe7pXWySGMi1xx4AQeEJ7rjkMYQ97i+pMuFFK3AdpxnHP2oV LzlD8Yfyc35lIVpeMbHWC768xaG25fI68a2++EdY5oNDVI3OPyvayWTGjUMW2fMlcSGu IUIwhFd/9N03XvrftQKO08Av0c1wnGunWQCejQhyCoxKowfO6hiL2A4J/kFWi8M9k2Lp 9fRDDo8uOYOYS0Zp9CxzV7OjrgOWVRlwiqfLej18D+NOeVWTUhBvzKtBEd2BmJ6PkQxS yNcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=Y0MPFE86YI3RBO0lK66R+fdU6zv8BYRhaifnG1fnmhc=; b=hnu8wGAFtqcmmOWxlUf2Qoe1fkzt0QuzpIHIneIJdkWEKfRpRiut9DNZ5xFE3aVRAj Gn6fxtVG4g3gXAxFSkIkNfeD0Y08wJdzD1I7DtywExgWc8yd8CJ1ntHYveU4dEMotY7o RwwHI6yMQ8i92K18PMUgQ2CllVubePEfjlfhoCfeuRknTak12FzYYKIupzw4wugLE1Qx pNR9TPSW2fW1DORQWg1oTBRi3JyT4RdKuNE5aP/PauO1gZKfrjsKt9JAc9FkExZ4zgVD OO62kLYqHv9A1WmMWxBaoiPoGP0f16Keqb9PKFPXfnKE+6Q1FFqDJrUT5jnU/sonfDfN KVHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr18si2301963ejc.34.2020.05.08.16.48.29; Fri, 08 May 2020 16:48:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728326AbgEHXrF (ORCPT + 99 others); Fri, 8 May 2020 19:47:05 -0400 Received: from mga17.intel.com ([192.55.52.151]:21510 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgEHXrF (ORCPT ); Fri, 8 May 2020 19:47:05 -0400 IronPort-SDR: qQAqKWwTDYPRUoHQD8UvVll2IubdOOpf2jXRhXwl5mbcivkMqCEyDrDy5VszM79VR9qwdEi4Rn Rc81C4UzM+sA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 16:47:04 -0700 IronPort-SDR: IgmrIChEafSOPxXY/UYw1Y2kWVyxeCtNJby66alTB8gI1u7A6peCARaxk9T6+QycGiiMk5J9/a peFREwyRD8Lg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="279186642" Received: from jbrandeb-mobl2.amr.corp.intel.com (HELO localhost) ([10.212.217.221]) by orsmga002.jf.intel.com with SMTP; 08 May 2020 16:47:03 -0700 Date: Fri, 8 May 2020 16:47:03 -0700 From: Jesse Brandeburg To: Nathan Chancellor Cc: Nick Desaulniers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Sedat Dilek , "kernelci . org bot" , Andy Shevchenko , Brian Gerst , "H . Peter Anvin" , "Ilie Halip" , , Marco Elver , "Paul E. McKenney" , Andrey Ryabinin , Luc Van Oostenryck , Andrew Morton , Masahiro Yamada , Daniel Axtens , "Peter Zijlstra (Intel)" , , Subject: Re: [PATCH v5] x86: bitops: fix build regression Message-ID: <20200508164703.0000481d@intel.com> In-Reply-To: <20200508202835.GA550540@ubuntu-s3-xlarge-x86> References: <20200508182835.228107-1-ndesaulniers@google.com> <20200508183230.229464-1-ndesaulniers@google.com> <20200508202835.GA550540@ubuntu-s3-xlarge-x86> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020 13:28:35 -0700 Nathan Chancellor wrote: > On Fri, May 08, 2020 at 11:32:29AM -0700, Nick Desaulniers wrote: > > Use the `%b` "x86 Operand Modifier" to instead force register allocation > > to select a lower-8-bit GPR operand. This looks OK to me, I appreciate the work done to find the right fix and clean up the code while not breaking sparse! I had a look at the assembly from gcc 9.3.1 and it looks good. Thanks! Reviewed-by: Jesse Brandeburg