Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Rob Herring'" <robh@kernel.org>
Cc:     <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <krzk@kernel.org>, <avri.altman@wdc.com>,
        <martin.petersen@oracle.com>, <kwmad.kim@samsung.com>,
        <stanley.chu@mediatek.com>, <cang@codeaurora.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <20200505155611.GA23690@bogus>
Subject: RE: [PATCH v7 06/10] dt-bindings: phy: Document Samsung UFS PHY
 bindings
Date:   Sat, 9 May 2020 06:06:10 +0530
Message-ID: <006801d62599$d8761690$896243b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQINaKJiJYqhfY8pF8dQGQjTbFgO/QHYsHSaAmfiCw4BzArg0Kf//KSQ
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200426173024.63069-1-alim.akhtar@samsung.com>
        <CGME20200426174215epcas5p3e87abccf47976f6318eb470efef9db39@epcas5p3.samsung.com>
        <20200426173024.63069-7-alim.akhtar@samsung.com>
        <20200505155611.GA23690@bogus>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob

> -----Original Message-----
> From: Rob Herring <robh=40kernel.org>
> Sent: 05 May 2020 21:26
> To: Alim Akhtar <alim.akhtar=40samsung.com>
> Cc: devicetree=40vger.kernel.org; linux-scsi=40vger.kernel.org; krzk=40ke=
rnel.org;
> avri.altman=40wdc.com; martin.petersen=40oracle.com;
> kwmad.kim=40samsung.com; stanley.chu=40mediatek.com;
> cang=40codeaurora.org; linux-samsung-soc=40vger.kernel.org; linux-arm-
> kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org
> Subject: Re: =5BPATCH v7 06/10=5D dt-bindings: phy: Document Samsung UFS =
PHY
> bindings
>=20
> On Sun, Apr 26, 2020 at 11:00:20PM +0530, Alim Akhtar wrote:
> > This patch documents Samsung UFS PHY device tree bindings
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
> > Tested-by: Pawe=C5=82=20Chmiel=20<pawel.mikolaj.chmiel=40gmail.com>=0D=
=0A>=20>=20---=0D=0A>=20>=20=20.../bindings/phy/samsung,ufs-phy.yaml=20=20=
=20=20=20=20=20=20=20=7C=2074=20+++++++++++++++++++=0D=0A>=20>=20=201=20fil=
e=20changed,=2074=20insertions(+)=0D=0A>=20>=20=20create=20mode=20100644=0D=
=0A>=20>=20Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml=0D=0A=
>=20>=0D=0A>=20>=20diff=20--git=0D=0A>=20>=20a/Documentation/devicetree/bin=
dings/phy/samsung,ufs-phy.yaml=0D=0A>=20>=20b/Documentation/devicetree/bind=
ings/phy/samsung,ufs-phy.yaml=0D=0A>=20>=20new=20file=20mode=20100644=0D=0A=
>=20>=20index=20000000000000..352d5dda320d=0D=0A>=20>=20---=20/dev/null=0D=
=0A>=20>=20+++=20b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.ya=
ml=0D=0A>=20>=20=40=40=20-0,0=20+1,74=20=40=40=0D=0A>=20>=20+=23=20SPDX-Lic=
ense-Identifier:=20GPL-2.0-only=20OR=20BSD-2-Clause=20%YAML=201.2=0D=0A>=20=
>=20+---=0D=0A>=20>=20+=24id:=0D=0A>=20>=20+https://protect2.fireeye.com/ur=
l?k=3D5c35df0a-01ffeabd-5c345445-0cc47a3=0D=0A>=20>=20+003e8-=0D=0A>=20aa6c=
980dab2ba33a&q=3D1&u=3Dhttp%3A%2F%2Fdevicetree.org%2Fschemas%2F=0D=0A>=20>=
=20+phy%2Fsamsung%2Cufs-phy.yaml%23=0D=0A>=20>=20+=24schema:=0D=0A>=20>=20+=
https://protect2.fireeye.com/url?k=3D9734fc5e-cafec9e9-97357711-0cc47a3=0D=
=0A>=20>=20+003e8-=0D=0A>=2079d176b992774339&q=3D1&u=3Dhttp%3A%2F%2Fdevicet=
ree.org%2Fmeta-schem=0D=0A>=20>=20+as%2Fcore.yaml%23=0D=0A>=20>=20+=0D=0A>=
=20>=20+title:=20Samsung=20SoC=20series=20UFS=20PHY=20Device=20Tree=20Bindi=
ngs=0D=0A>=20>=20+=0D=0A>=20>=20+maintainers:=0D=0A>=20>=20+=20=20-=20Alim=
=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0A>=20>=20+=0D=0A>=20>=20+proper=
ties:=0D=0A>=20>=20+=20=20=22=23phy-cells=22:=0D=0A>=20>=20+=20=20=20=20con=
st:=200=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20compatible:=0D=0A>=20>=20+=20=20=
=20=20enum:=0D=0A>=20>=20+=20=20=20=20=20=20-=20samsung,exynos7-ufs-phy=0D=
=0A>=20>=20+=0D=0A>=20>=20+=20=20reg:=0D=0A>=20>=20+=20=20=20=20maxItems:=
=201=0D=0A>=20>=20+=20=20=20=20description:=20PHY=20base=20register=20addre=
ss=0D=0A>=20=0D=0A>=20Can=20drop=20the=20description.=20Doesn't=20add=20any=
thing=20special.=0D=0A>=20=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20reg-names:=0D=
=0A>=20>=20+=20=20=20=20items:=0D=0A>=20>=20+=20=20=20=20=20=20-=20const:=
=20phy-pma=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20clocks:=0D=0A>=20>=20+=20=20=
=20=20items:=0D=0A>=20>=20+=20=20=20=20=20=20-=20description:=20PLL=20refer=
ence=20clock=0D=0A>=20>=20+=20=20=20=20=20=20-=20description:=20symbol=20cl=
ock=20for=20input=20symbol=20(=20rx0-ch0=20symbol=20clock)=0D=0A>=20>=20+=
=20=20=20=20=20=20-=20description:=20symbol=20clock=20for=20input=20symbol=
=20(=20rx1-ch1=20symbol=20clock)=0D=0A>=20>=20+=20=20=20=20=20=20-=20descri=
ption:=20symbol=20clock=20for=20output=20symbol=20(=20tx0=20symbol=0D=0A>=
=20>=20+=20clock)=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20clock-names:=0D=0A>=20=
>=20+=20=20=20=20items:=0D=0A>=20>=20+=20=20=20=20=20=20-=20const:=20ref_cl=
k=0D=0A>=20>=20+=20=20=20=20=20=20-=20const:=20rx1_symbol_clk=0D=0A>=20>=20=
+=20=20=20=20=20=20-=20const:=20rx0_symbol_clk=0D=0A>=20>=20+=20=20=20=20=
=20=20-=20const:=20tx0_symbol_clk=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20samsun=
g,pmu-syscon:=0D=0A>=20>=20+=20=20=20=20=24ref:=20'/schemas/types.yaml=23/d=
efinitions/phandle'=0D=0A>=20>=20+=20=20=20=20description:=20phandle=20for=
=20PMU=20system=20controller=20interface,=20used=20to=0D=0A>=20>=20+=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20control=20pmu=20registers=20bi=
ts=20for=20ufs=20m-phy=0D=0A>=20>=20+=0D=0A>=20>=20+required:=0D=0A>=20>=20=
+=20=20-=20=22=23phy-cells=22=0D=0A>=20>=20+=20=20-=20compatible=0D=0A>=20>=
=20+=20=20-=20reg=0D=0A>=20>=20+=20=20-=20reg-names=0D=0A>=20>=20+=20=20-=
=20clocks=0D=0A>=20>=20+=20=20-=20clock-names=0D=0A>=20>=20+=20=20-=20samsu=
ng,pmu-syscon=0D=0A>=20=0D=0A>=20Add:=0D=0A>=20=0D=0A>=20additionalProperti=
es:=20false=0D=0A>=20=0D=0A>=20With=20that,=0D=0A>=20=0D=0AWill=20update=20=
the=20documentation=20as=20per=20your=20suggestion=0D=0A=0D=0A>=20Reviewed-=
by:=20Rob=20Herring=20<robh=40kernel.org>=0D=0A>=0D=0AThanks=20for=20review=
=20comments.=20After=20fixing,=20will=20add=20your=20review=20tag.=0D=0A=20=
=0D=0A>=20>=20+=0D=0A>=20>=20+examples:=0D=0A>=20>=20+=20=20-=20=7C=0D=0A>=
=20>=20+=20=20=20=20=23include=20<dt-bindings/clock/exynos7-clk.h>=0D=0A>=
=20>=20+=0D=0A>=20>=20+=20=20=20=20ufs_phy:=20ufs-phy=4015571800=20=7B=0D=
=0A>=20>=20+=20=20=20=20=20=20=20=20compatible=20=3D=20=22samsung,exynos7-u=
fs-phy=22;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20reg=20=3D=20<0x15571800=20=
0x240>;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20reg-names=20=3D=20=22phy-pma=
=22;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20samsung,pmu-syscon=20=3D=20<&pmu=
_system_controller>;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=23phy-cells=20=
=3D=20<0>;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20clocks=20=3D=20<&clock_fsy=
s1=20SCLK_COMBO_PHY_EMBEDDED_26M>,=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20<&clock_fsys1=20PHYCLK_UFS20_RX1_SYMBOL_USER>,=
=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20<&clock_f=
sys1=20PHYCLK_UFS20_RX0_SYMBOL_USER>,=0D=0A>=20>=20+=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20<&clock_fsys1=20PHYCLK_UFS20_TX0_SYMBOL_USER>=
;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20clock-names=20=3D=20=22ref_clk=22,=
=20=22rx1_symbol_clk=22,=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=22rx0_symbol_clk=22,=20=22tx0_symbol_clk=22;=
=0D=0A>=20>=20+=0D=0A>=20>=20+=20=20=20=20=7D;=0D=0A>=20>=20+...=0D=0A>=20>=
=20--=0D=0A>=20>=202.17.1=0D=0A>=20>=0D=0A=0D=0A