Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 9 May 2020 13:14:34 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Christian =?UTF-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Christoph Hellwig <hch@lst.de>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Andy Lutomirski <luto@kernel.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Borislav Petkov <bp@alien8.de>,
        Chris Zankel <chris@zankel.net>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Helge Deller <deller@gmx.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Huang Rui <ray.huang@amd.com>, Ingo Molnar <mingo@redhat.com>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: vmwgfx: include linux/highmem.h
Message-ID: <20200509131434.27ddccb9@canb.auug.org.au>
In-Reply-To: <20200508220150.649044-1-arnd@arndb.de>
References: <20200508220150.649044-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/LruK9RrFyqBl+3yphC.Izb2";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/LruK9RrFyqBl+3yphC.Izb2
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Arnd,

On Sat,  9 May 2020 00:01:31 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> In order to call kmap_atomic() etc, we need to include linux/highmem.h:
>=20
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration o=
f function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=3Dimplicit-f=
unction-declaration]
>   377 |    kunmap_atomic(d->src_addr);
>       |    ^~~~~~~~~~~~~
>       |    in_atomic
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration o=
f function 'kmap_atomic_prot' [-Werror=3Dimplicit-function-declaration]
>   391 |     kmap_atomic_prot(d->dst_pages[dst_page],
>       |     ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *=
' {aka 'unsigned char *'} from 'int' makes pointer from integer without a c=
ast [-Wint-conversion]
>   390 |    d->dst_addr =3D
>       |                ^
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *=
' {aka 'unsigned char *'} from 'int' makes pointer from integer without a c=
ast [-Wint-conversion]
>   403 |    d->src_addr =3D
>       |                ^
>=20
> Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgf=
x/vmwgfx_blit.c
> index 94d456a1d1a9..1629427d5734 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> @@ -27,6 +27,7 @@
>   ***********************************************************************=
***/
> =20
>  #include "vmwgfx_drv.h"
> +#include <linux/highmem.h>
> =20
>  /*
>   * Template that implements find_first_diff() for a generic
> --=20
> 2.26.0
>=20

Added to linux-next for Monday (in case Andrew doesn't get around to it).

--=20
Cheers,
Stephen Rothwell

--Sig_/LruK9RrFyqBl+3yphC.Izb2
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl62IBoACgkQAVBC80lX
0GwnAgf/UN+9W0C6W35cVuOUG1IADDrDP9dNx5i7CYj/hbyhYDo3V4Y7B1gtANBP
YIKfKxM4GuolXI6HhF6hj8ukF+UX3cI45+6adqA+1wD2MfHa8694yyrgj4sWE9wn
t4/7W2DTjKMuh0YDZOjs2ufEAECwgTOUIOH+AZiWvko4bqRwSjK6lqIqsbhZf842
mq7MGEs1R8Ke/Q2BpNGLvoj8HRw4/zdrTy+uR2nDdpEshacKE05UllaEcvOg8iWo
hAaakwFXIg44JuidWrwGH3pdr81cK3vBnYubx5rHdyxxlQ8GeIsIMrtcbvtMwWxQ
OaLntmpT6n0hTJKeFYoR5Zg7nXsHRA==
=0wW0
-----END PGP SIGNATURE-----

--Sig_/LruK9RrFyqBl+3yphC.Izb2--