Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp140692ybk; Fri, 8 May 2020 21:41:35 -0700 (PDT) X-Google-Smtp-Source: APiQypIZRxV+bfX4SvoPbQrxGcFUwTqBOfo3YbGuUl8yAP3QbpZ/V1eFFQTL3z1DRDQp7GcdMEEQ X-Received: by 2002:a05:6402:1766:: with SMTP id da6mr4852040edb.119.1588999295638; Fri, 08 May 2020 21:41:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588999295; cv=none; d=google.com; s=arc-20160816; b=bNEUeB4N8RjtHzBP3hUQ/o1BUQflkN7TJFJ7X/PIvNI/vH2NDGTSne9ijXWjNLR0pw mqFaMygn+c5pWZlEd4P51RlFm7uJ29UIflc3RleFJvVOL6tQlePPaPSEMW2Ct/3kx/B9 XLeQK7zrE/aYUb0wlsynbIwmEHgQUeP1mksWfOUX7tNONgr0f49ohMsga4etplI6AyW6 zmSSMTaRPtFsm15YXRywPH5P8mng15vCTHxf26ynkkllcFaqSwZGG/nFgFt5/B9AXtll 4bY8J51x9OqHER8DGJtUGLNhZe/6VZN5vKJpsg4Env+KNtXbghiNdKAuigWnAhjNCz30 SehQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=R8OF7M46D8C3jXOaoBlaMReTLKc3NpL8x+JXeBlXDQg=; b=WsXDx7DuzuIJnnTMy97j0y6nJYktJQ8FevMX9vCBXVHwU8KQu8iombE6f3Q2aljFWl VdB9PY7jQJtfmkb9NY66bJY96rWsATUYSzD4a+b6EO9sNhCkt559xIGKkhDwEH2f2mRP j4mLsHxRZAgU0/HdRQC9bqshIHrw3QqmIdteHnit1s05MTKCnJ4el6BpGD+8B/G+uia7 erF+GRW+ljhd0ej61AaY3OkHB9cnrpa5YaSMYBcSYiCBhA01rlS4vIrmsgDPex+wowca YUW4fboNlIizILVHAetsXNaLNsZWQ1HimFo4ibdsh5Oxp20pMo/MYuUngGvPZoP6rFC4 3Igw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di17si2073474edb.593.2020.05.08.21.41.13; Fri, 08 May 2020 21:41:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728944AbgEIEg6 (ORCPT + 99 others); Sat, 9 May 2020 00:36:58 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:33924 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728789AbgEIEgM (ORCPT ); Sat, 9 May 2020 00:36:12 -0400 Received: by mail-pj1-f65.google.com with SMTP id h12so5932031pjz.1; Fri, 08 May 2020 21:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R8OF7M46D8C3jXOaoBlaMReTLKc3NpL8x+JXeBlXDQg=; b=nvcAwBwQZEc1lhm0aTUd7bqmWD0Ukv1tpbmzlUqeSyXpTDA+DZvi+93KaJ9E/NevpC 5TKMOECAxCbY6REFmzfjSMlemCek0BDCl2RFzzNEkCK4jOEYlM5p8ypzLF4EYMsYaNmx CxwjhmEB4Sp6a4BRn8Z2Yu8z0jMVj3/FjzDq+v/FfLsxlGMre0AHHMfEFv4ZKfXorMs/ pDCFgfZusTAFA5vhzjPACurJMs5t7Y2w7aBDGJ/Pj5lEvNpxUlSrEADrhFSo2QFSyrtG cFqAre0aHMEHqoTWVzHjynCj2Vcwyn8gJs852bApLN/kn/gS+soLCFyLDxunT7whWaPl M6PQ== X-Gm-Message-State: AGi0PuaLZVEv3BxSaTUVVKhbikTTSi1jInjMbCp87xE3HDzOJoIA+XOM 2SB4QkbABAnjSrEmk8Yosf0= X-Received: by 2002:a17:902:eb4b:: with SMTP id i11mr5451742pli.19.1588998971874; Fri, 08 May 2020 21:36:11 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l15sm3565848pjk.56.2020.05.08.21.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 1D69742079; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Vishal Kulkarni Subject: [PATCH 07/15] cxgb4: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:44 +0000 Message-Id: <20200509043552.8745-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index a70018f067aa..c67fc86c0e42 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -3646,6 +3646,7 @@ void t4_fatal_err(struct adapter *adap) * could be exposed to the adapter. RDMA MWs for example... */ t4_shutdown_adapter(adap); + module_firmware_crashed(); for_each_port(adap, port) { struct net_device *dev = adap->port[port]; -- 2.25.1