Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp142744ybk; Fri, 8 May 2020 21:46:36 -0700 (PDT) X-Google-Smtp-Source: APiQypJ30rzo5aZxRoU8iVtioVeDkrH3axgoMl0J0vNcCbinmea/ZeBgB2z2baINF/vt2gOhuf4j X-Received: by 2002:a17:906:ca49:: with SMTP id jx9mr4603991ejb.246.1588999596801; Fri, 08 May 2020 21:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588999596; cv=none; d=google.com; s=arc-20160816; b=0O03lITyQBD1R/ZHcBOFj3BuWAulm1nMMvCcR+bCM5SNqxeY42AyloBKDTeGyA4D+r DStl8lqZLLISymrhgaMiY1SQczi/eYLx4y1YslYE3+Oqr90fEmfSkE81E3xYFa1qpJv2 YJIiH/f3ipa7TnTxpfE6q9p1uVvM2zEsYwnr7vh6qHPcq6FDFniCyRRQgJYfBAiyHmBU NOnxU3U9NKAuNA2ma8bfkPssb8if1khX2l58Yku+jXIjJ9q7vVPK5xeeV6DPu/bjVoyz IPDRmTuJp3XH00Y3jDIDaqWX4e1qc1eGMmoU6Au04h3067uSPl9p6S6nQBRkjEbjdmzN VPdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:dkim-signature; bh=MRnH5k9ZI9zg5bBwtUec2EUFq39SVuIpRRMAftUUCeQ=; b=eUhwKYDsdolfwjU5WixY6NKZoT7THPYM6MzZbxdX2rzFp98mYRBV9M+jRa3w2PkZmo 3FTnoJPazsCsnFsk/OChmqADD9okShFnSlPlcVdjbog+VdgqQ7bf/u58L7lRHBELmxA7 qPERbMIn92CEjl4YlcVJBTj9FcW5B6S8BUpxMXOOcR5S9aUFyGA3JcQba55luUHa+4pv REGVR/c81ChBsWJYLVPxemjGplrBVeCswSq/z+bmIYaZZcmjXowfRN9XGFxbauaydyxR kfomxTzb4rKCSmhl0WSiYD4CsaMOHqUkqCvlxx6zoEGylpMGnwyuoQs/P9RiQD+VS3Qs hHnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pouY5t34; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f26si2118437edj.20.2020.05.08.21.46.13; Fri, 08 May 2020 21:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pouY5t34; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgEIEoy (ORCPT + 99 others); Sat, 9 May 2020 00:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgEIEox (ORCPT ); Sat, 9 May 2020 00:44:53 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82036C061A0C for ; Fri, 8 May 2020 21:44:53 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id j3so3826578ljg.8 for ; Fri, 08 May 2020 21:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=MRnH5k9ZI9zg5bBwtUec2EUFq39SVuIpRRMAftUUCeQ=; b=pouY5t34NrhTXy1cRVhZTkVj0Vz+TvTPUeb9CGHBENQ+rOH3CjUzxpDI7qNzs3oAFx 2Ibs87NF4nNXWQnQl0OA0WXbhwv6dxcTaoeXEu1obOwGFq34Dm/wiGu5nVHSwdKyJ/iP QkcUgIAej5ariJQrMB1GSbpj9j9SF6DszX/r13uVYj/UsgGe0hHhvXHtLdEtOMmCJG5X 3STqswNY7tn0AzJNgPiLI1MzqQdqNkvz+40nZOC9gqll8ujByvqvQvgIfhD0WfiVJumq SPiXXd9OuQirzrv4czEVNSo7f+dn0+W3moAcCufDO+Amroftvt96fAPAXdhRjxz2o3xE OSdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=MRnH5k9ZI9zg5bBwtUec2EUFq39SVuIpRRMAftUUCeQ=; b=cG7IbNRA+1CbjXlVaRVScMFYXUBNTcvIJyIFmQQkHa5tXaHwRr1n3NUMIGAPsRBH2A Tn4wNJRuEVdO07Nd1WafgHdMLwoXNUs0PtHGmqdWcqHB189z1PsUbuXiXuyC0hz7tZt/ 883JRiLItDaYYcbXA2EnSowg1V3pR+bfafgB0MX0fIdIHKeh7AcKTkt1w9Cq4GMLyzJN Ks/ymLKRzW+R6++Cio2zy1YVKyIn+Mh53aY45yA2GjNRlbH7Z55qEVDDMi5lZANi3DLm twQzDkddo5wSH8RweB9UYlyUCdHRHV6pQ/euniSofrJbfn/m0XmPdn7Dopv+awtpMGBj bqYA== X-Gm-Message-State: AOAM533cW/yuOCoVOf/t9Giv1nM4yZqupbtrWHIvwYzrc06cawkiWnUz 8ZjgqPBJmhOKsGACqIvHpxDkygyLtS+gnccOAYk= X-Received: by 2002:a05:651c:385:: with SMTP id e5mr3709241ljp.208.1588999491978; Fri, 08 May 2020 21:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20200508182835.228107-1-ndesaulniers@google.com> <20200508183230.229464-1-ndesaulniers@google.com> <20200508202835.GA550540@ubuntu-s3-xlarge-x86> <20200508164703.0000481d@intel.com> In-Reply-To: <20200508164703.0000481d@intel.com> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Sat, 9 May 2020 06:44:40 +0200 Message-ID: Subject: Re: [PATCH v5] x86: bitops: fix build regression To: Jesse Brandeburg Cc: Nathan Chancellor , Nick Desaulniers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "kernelci . org bot" , Andy Shevchenko , Brian Gerst , "H . Peter Anvin" , Ilie Halip , x86@kernel.org, Marco Elver , "Paul E. McKenney" , Andrey Ryabinin , Luc Van Oostenryck , Andrew Morton , Masahiro Yamada , Daniel Axtens , "Peter Zijlstra (Intel)" , linux-kernel@vger.kernel.org, Clang-Built-Linux ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 9, 2020 at 1:47 AM Jesse Brandeburg wrote: > > On Fri, 8 May 2020 13:28:35 -0700 > Nathan Chancellor wrote: > > > On Fri, May 08, 2020 at 11:32:29AM -0700, Nick Desaulniers wrote: > > > Use the `%b` "x86 Operand Modifier" to instead force register allocation > > > to select a lower-8-bit GPR operand. > > This looks OK to me, I appreciate the work done to find the right > fix and clean up the code while not breaking sparse! I had a look at > the assembly from gcc 9.3.1 and it looks good. Thanks! > > Reviewed-by: Jesse Brandeburg > Tested v5 on Debian/testing AMD64 with a selfmade llvm-toolchain (LLVM/Clang/LLD) v10.0.1+git92d5c1be9ee9 Please add: Tested-by: Sedat Dilek For details see Thanks to all involved people. - Sedat -