Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp150619ybk; Fri, 8 May 2020 22:04:59 -0700 (PDT) X-Google-Smtp-Source: APiQypIx+ZYZbn1l0+bJRFzQU6mbpEtpssMjIXnXJi4RLfqKVkHdQNNIS6x5JEAj9GMsKZlWG6Wx X-Received: by 2002:a17:906:edb5:: with SMTP id sa21mr4881804ejb.270.1589000699804; Fri, 08 May 2020 22:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589000699; cv=none; d=google.com; s=arc-20160816; b=DwHT9AUtYnR7vuMr7nfT0u3R4SgLtadfjTie5C3a3L1TvzI0Z4zq8RIOj1zKfu8cWG KUb6TLAr5UUHttEMJ1WE81n5CScoXOyvNHAUI2uBQ0RRkbbHfCqOwkIAVUkdFoPl4Hnq VlpnaxRo0YqH3WA6S8L+UZresWAbzXdpk7ixhhLrhtpaUxVneVfgbj7e7X1OeQk2Qgxf FRFyb/wP0a9LnwhpKZitJECToGS7O8k52BsBhCcuN+662OuEavNVKtpHkJqMZfcOi8TE FbE7Gyst3nKR7JkHKNXXh/1N8DZIMxVGUBgy0v3FFBaK5J+fYL8+r02kuihiz5EqIPU7 LrIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PblejXFYFxaChyYzck5O6k4FzOta65rmQVFP7KD8dDg=; b=D11g8Cp6D2lAO+iShRoTd03R4LYl7uaPAfVkwMWPtPy/XTZeAdXU0p26CTS1JF1VBs PpSn0syEzgjSCem12gmojMdAOMuryd2Nvr+Ac6/OnoluyXIDP09ftSB6ACrVRAu3ff4O MVOkOv7QX+ZMS2kz/uu4ASBUDz170130hAZuqMyomj6CJ0+L9yk0ziDz2EE5ZadJx2KF LgNuxyq7UBYZ6KNquSa/zMio2MTOh7xAimqMersdVRKwJAit5d+TCwQAhiAUX0qgxpPQ gdHUJwMsMG8GZVnhpCiIbck7PKBHQwiA9sLdb/uraFZ/nVv91Ay6Pu3p8GFXlru7DaYr lFUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K0XYe8pN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si2440351edl.591.2020.05.08.22.04.34; Fri, 08 May 2020 22:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K0XYe8pN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725960AbgEIFCz (ORCPT + 99 others); Sat, 9 May 2020 01:02:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgEIFCz (ORCPT ); Sat, 9 May 2020 01:02:55 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ECD5C05BD09 for ; Fri, 8 May 2020 22:02:55 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id s20so1648929plp.6 for ; Fri, 08 May 2020 22:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PblejXFYFxaChyYzck5O6k4FzOta65rmQVFP7KD8dDg=; b=K0XYe8pNJk7c0tNMRMrjfQ0YToPM8NiUVzaX3KFDHke/snEmuq7h/XsZYu2ll9ki92 6O7Wyzy0mbCS1pKi8Nv1vZHVLMOGsxEd6/5/Hat1vvegmDz6COknREZ/Ni/eX21S4YIi wVAoeWLD9ljworD0PqPubniB5hZ/u3V3GAbdA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PblejXFYFxaChyYzck5O6k4FzOta65rmQVFP7KD8dDg=; b=VoKkl+JvDklsuRkxPwwVp954R7mQj4olsplV6u9KffvEi+ziJRF0PGQuSsbSfMu6Bg qZ+vtKrCPfGg1PfbVWFlmCPL9bvR6uIFwMGbbDEiZj9eVJEhzkMjHDjNCNRB4Q4mm3Tf dyx5IULZZ7h4Vq2dbb3imNgRzC5GAvZa1lJ79H5OcZwGvDrxbxbLJN/BWDFSiU3koxpw J1dhyZsW27ca71JhLeDL3virxjn6l2W9pD4nugJOYmWU9fIVP9D3F70T+PoSfBJ1yaJs kBT0wr8t/3qInN/31uzhy06a3xmc/sQpSjQd8e5PLobGdqVNBylYe85zrXTMGV1Hd22S Deww== X-Gm-Message-State: AGi0Puapq6kth8aY1WIug6N3D2rEOEJrhAr1F2kLxPVkdCCTQkWFoIOg k5nzZU6HaOMGx7AyOGrxfvdCFg== X-Received: by 2002:a17:902:59cd:: with SMTP id d13mr5390945plj.329.1589000574672; Fri, 08 May 2020 22:02:54 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c15sm3415031pfp.34.2020.05.08.22.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 22:02:53 -0700 (PDT) Date: Fri, 8 May 2020 22:02:52 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton Subject: Re: [PATCH 1/6] exec: Move the comment from above de_thread to above unshare_sighand Message-ID: <202005082202.567DED45B0@keescook> References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87sgga6ze4.fsf@x220.int.ebiederm.org> <87mu6i6zcs.fsf_-_@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mu6i6zcs.fsf_-_@x220.int.ebiederm.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 01:44:19PM -0500, Eric W. Biederman wrote: > > The comment describes work that now happens in unshare_sighand so > move the comment where it makes sense. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook