Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <131136.1588999639@turing-police>
In-Reply-To: <131136.1588999639@turing-police>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 9 May 2020 16:51:00 +0900
Message-ID: <CAK7LNAT2xMR9fq+bJCc=1wLuEM99fPNagDc=NkFoDKNi-YCpDg@mail.gmail.com>
Subject: Re: [PATCH] bpfilter: document build requirements for bpfilter_umh
To:     =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>
Cc:     Sam Ravnborg <sam@ravnborg.org>,
        "David S. Miller" <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 9, 2020 at 1:47 PM Valdis Kl=C4=93tnieks <valdis.kletnieks@vt.e=
du> wrote:
>
> It's not intuitively obvious that bpfilter_umh is a statically linked bin=
ary.
> Mention the toolchain requirement in the Kconfig help, so people
> have an easier time figuring out what's needed.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>

Applied to linux-kbuild.
Thanks.


> diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
> index fed9290e3b41..0ec6c7958c20 100644
> --- a/net/bpfilter/Kconfig
> +++ b/net/bpfilter/Kconfig
> @@ -13,4 +13,8 @@ config BPFILTER_UMH
>         default m
>         help
>           This builds bpfilter kernel module with embedded user mode help=
er
> +
> +         Note: your toolchain must support building static binaries, sin=
ce
> +         rootfs isn't mounted at the time when __init functions are call=
ed
> +         and do_execv won't be able to find the elf interpreter.
>  endif
>


--=20
Best Regards
Masahiro Yamada