Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200425054659.814774-1-masahiroy@kernel.org> <CAK7LNAQk_fLFCWuFCC0NK3nxVE0bs-n7E+T-dbn14aCZVg_pgQ@mail.gmail.com>
 <20200508214650.GA3482@ls3530.fritz.box>
In-Reply-To: <20200508214650.GA3482@ls3530.fritz.box>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 9 May 2020 17:16:04 +0900
Message-ID: <CAK7LNAS0PVA7stUE9nmOuiP=MfPGDp1u-QDzfpk7Juq-JFehVw@mail.gmail.com>
Subject: Re: [PATCH] parisc: suppress error messages for 'make clean'
To:     Helge Deller <deller@gmx.de>
Cc:     "James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
        linux-parisc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Helge,

On Sat, May 9, 2020 at 6:46 AM Helge Deller <deller@gmx.de> wrote:
>
> * Masahiro Yamada <masahiroy@kernel.org>:
> > On Sat, Apr 25, 2020 at 2:47 PM Masahiro Yamada <masahiroy@kernel.org> =
wrote:
> > >
> > > 'make ARCH=3Dparisc clean' emits a tons of error messages as follows:
> > >
> > >   $ make ARCH=3Dparisc clean
> > >   gcc: error: unrecognized command line option '-mno-space-regs'
> > >   gcc: error: unrecognized command line option '-mfast-indirect-calls=
'; did you mean '-mforce-indirect-call'?
> > >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> > >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> > >   gcc: error: unrecognized command line option '-mno-space-regs'
> > >   gcc: error: unrecognized command line option '-mfast-indirect-calls=
'; did you mean '-mforce-indirect-call'?
> > >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> > >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> > >     ...
> > >
> > > You can supporess them except '-Wframe-larger-than' by setting correc=
t
> > > CROSS_COMPILE=3D, but we should not require any compiler for cleaning=
.
> > >
> > > This $(shell ...) is evaluated so many times because LIBGCC is export=
ed.
> > > Use the ':=3D' operator to evaluate it just once, and sink the stderr=
.
> > >
> >
> > Applied to linux-kbuild.
>
> That patch breaks then building the boot loader/compressor:
> ...
>   hppa-linux-gnu-ld    -X -e startup --as-needed -T arch/parisc/boot/comp=
ressed/vmlinux.lds arch/parisc/boot/compressed/head.o arch/parisc/boot/comp=
ressed/real2.o arch/parisc/boot/compressed/firmware.o arch/parisc/boot/comp=
ressed/misc.o arch/parisc/boot/compressed/piggy.o -o arch/parisc/boot/compr=
essed/vmlinux
> hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `dec_v=
li':
> (.text+0x104): undefined reference to `__ashldi3'
> hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `lzma_=
len':
> (.text+0x2b0): undefined reference to `$$mulI'
> hppa-linux-gnu-ld: (.text+0x344): undefined reference to `$$mulI'
> hppa-linux-gnu-ld: (.text+0x3f8): undefined reference to `$$mulI'
>
>
> The patch below works, but I wonder if it's possible to avoid
> to examine LIBGCC twice....?
>
> Helge


Sorry for the breakage.

How about moving LIBGCC below ?


diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index d82787da43cd..6b37aa37a365 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -21,8 +21,6 @@ KBUILD_IMAGE :=3D vmlinuz

 NM             =3D sh $(srctree)/arch/parisc/nm
 CHECKFLAGS     +=3D -D__hppa__=3D1
-LIBGCC         :=3D $(shell $(CC) $(KBUILD_CFLAGS)
-print-libgcc-file-name 2>/dev/null)
-export LIBGCC

 ifdef CONFIG_64BIT
 UTS_MACHINE    :=3D parisc64
@@ -114,6 +112,10 @@ KBUILD_CFLAGS      +=3D $(cflags-y)
 kernel-y                       :=3D mm/ kernel/ math-emu/

 core-y +=3D $(addprefix arch/parisc/, $(kernel-y))
+
+LIBGCC :=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name 2>/dev/=
null)
+export LIBGCC
+
 libs-y +=3D arch/parisc/lib/ $(LIBGCC)

 drivers-$(CONFIG_OPROFILE)             +=3D arch/parisc/oprofile/


>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 628cd8bb7ad8..aeea20abbf01 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -21,8 +21,7 @@ KBUILD_IMAGE :=3D vmlinuz
>
>  NM             =3D sh $(srctree)/arch/parisc/nm
>  CHECKFLAGS     +=3D -D__hppa__=3D1
> -LIBGCC         =3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-nam=
e)
> -export LIBGCC
> +LIBGCC         :=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-na=
me)
>
>  ifdef CONFIG_64BIT
>  UTS_MACHINE    :=3D parisc64
> diff --git a/arch/parisc/boot/compressed/Makefile b/arch/parisc/boot/comp=
ressed/Makefile
> index 1e5879c6a752..b008cf1b5c1e 100644
> --- a/arch/parisc/boot/compressed/Makefile
> +++ b/arch/parisc/boot/compressed/Makefile
> @@ -22,6 +22,8 @@ ifndef CONFIG_64BIT
>  KBUILD_CFLAGS +=3D -mfast-indirect-calls
>  endif
>
> +LIBGCC  :=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
> +
>  OBJECTS +=3D $(obj)/head.o $(obj)/real2.o $(obj)/firmware.o $(obj)/misc.=
o $(obj)/piggy.o
>
>  LDFLAGS_vmlinux :=3D -X -e startup --as-needed -T


--=20
Best Regards
Masahiro Yamada