Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp246853ybk; Sat, 9 May 2020 01:34:18 -0700 (PDT) X-Google-Smtp-Source: APiQypKuXdYpqehkopsgmzQEDodUZwgCtKLctP5eCO4+/6MbjQOEGqtzJQUDjCtWGBYLU+IhULkp X-Received: by 2002:aa7:d794:: with SMTP id s20mr5583460edq.141.1589013257854; Sat, 09 May 2020 01:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589013257; cv=none; d=google.com; s=arc-20160816; b=00kQRuJdNyiisnwTyjZmejUQdXpiJr/nZULR/HPagrllzPMqWWunrl1WcrdLUrxbj5 BR8ixruiIQweAL+it3/jeyl3BL2XAk3WuypOHa7GXAySjUzpdo3i+VEQbedE67KoYM/K 7LjVycZ4GDOEIc7qyfIKJDWjrt5yEcuKAVL1mxEmILJf43e901ruFPf9zdhjEjMMhkjh YpKhRGQ5tFKhkzM7vLA8bAmfv+nib90eFRr8pIlS6ZoSAPomYcf/jUV4JaaZ5CVylZDG wTJAH0jlPFAIfjh7EqMitVcIOrFPWMczXwUMZ87rVeR38w4E9f3c5eqTDHvTl5PhJXWt drbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=peLvqahApCXlAKnnF8w/bg1cqALJbiZS/A1EF+xPi00=; b=UWliaAlpy2k4uW61Cx3w4o303loVUm5X8Z68Zde9xhTdRQz26gQNh+YwxYSDsIwpBD sHiLh3EGw3OwnFGjAd5IFwv04EjBpIdEoPqwF7oBBTaZmlqTqRAgn3yLxCsAa42ZIryP YclnQ+tkcAkkneXsvh5R5UDc/hEfkwpnX/i5ceNekr1N0RchBpnqBrtAssZ/L7VcHgYu dtdMt2MqzprG4l783FqB6/n6h0zxWxmF4BRsZLqz1gxXQ2N7wW5WvwaQn+gUo3RBcPl8 +NlbPMSVONAR2QuAzXI/0hnNc9ERG12ZJc4OzhK4sHLtHG1tNmToRmdRyNX3feS3QIpO NyMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LrbMYBHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si2357897ejs.504.2020.05.09.01.33.55; Sat, 09 May 2020 01:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LrbMYBHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbgEIIcc (ORCPT + 99 others); Sat, 9 May 2020 04:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728055AbgEIIcb (ORCPT ); Sat, 9 May 2020 04:32:31 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74CDFC061A0C for ; Sat, 9 May 2020 01:32:31 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id r14so2234622pfg.2 for ; Sat, 09 May 2020 01:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=peLvqahApCXlAKnnF8w/bg1cqALJbiZS/A1EF+xPi00=; b=LrbMYBHzrTEwUubsD4bXrHd/O12wcfnLcBB2xQEAly6vOFT1BbjY/OqmXAH2/UgrNe Bn2Ntnvlc6r64PRHhJdWxMwdWuWrDeGeaJCa6Y5mRpDFTa9XTtWM919aSunq6GHWU9K0 aHVu8iGJBhVUs03cl/333GJrymWHOWRgkAPM53+dXf8LAlErRZQuQGtFxe96Wr743hkm mXcbSS2jWNM8RRZqxVgNqCy9bQNpWbG9RPEH0nG7QER5kRsNLQaSyf7BFIupJpVOHYin y0vKJKK71+7a7+wddE17YP3Fgc22b5V9aNw7LcMvUBa7ezSd3tOYnGhnutguBQAjT5Wh gB1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=peLvqahApCXlAKnnF8w/bg1cqALJbiZS/A1EF+xPi00=; b=Ha2W7ncvTr+KY2rcHnbgKMnLUs0dLFBEqS/uC8hm71gOIR52ltHTKlX/e57A4aNru6 t2w1FV9T6ELiu+RySe95FsjVfl3jKj+DnYDgWZbCgUhtPMHEif+voMxBKQRYdmPCc5Wy JY6hRkgr8V3Xfj3eML3R3oi/9JSSR2eDfkil6tmvt2s+vcDDC8LCHN9MpK0fyVwamfRk FalLsl4uNb7iRDmItuHTn1/tqNULR6wxhkO+e7WQGw+AHzDBVlbQu6MhgONYV3AA9Phz ueTXXVHDexwYpUQHFsea2KALoEaxe5cBLoSxpqzsledDNSoq6hkedW401Mkp9qjADVNS VK6Q== X-Gm-Message-State: AGi0PuYWKNyLaLkvyYGSkHi+8QXYLA3MmYCXwRPLFkBe5Xdq3akNy/pi nvN2TiX1XilE/P59iG8Lqv6w X-Received: by 2002:aa7:9ac9:: with SMTP id x9mr6681146pfp.304.1589013150928; Sat, 09 May 2020 01:32:30 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6e0c:55d2:2cb4:da01:ad1e:6ad9]) by smtp.gmail.com with ESMTPSA id h13sm3044895pgm.69.2020.05.09.01.32.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 May 2020 01:32:30 -0700 (PDT) Date: Sat, 9 May 2020 14:02:23 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org Subject: Re: [PATCH v7 0/8] Bug fixes and improved logging in MHI Message-ID: <20200509083222.GJ5845@Mani-XPS-13-9360> References: <1588991208-26928-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588991208-26928-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bhaumik, On Fri, May 08, 2020 at 07:26:40PM -0700, Bhaumik Bhatt wrote: > A set of patches for bug fixes and improved logging in mhi/core/boot.c. > Verified on x86 and arm64 platforms. > Series applied to mhi-next! I'll wait for one more -rc before sending the final series to Greg for v5.8. If any other series gets reviewed by that point, I'll club them together for the final one. Thanks, Mani > v7: > -Updated commit text for macro inclusion > -Updated channel ID bound checks > -Fixed non-uniform placement of function parameters to be within 80 characters > -Sent to correct Maintainer email ID > > v6: > -Updated the MHI_RANDOM_U32_NONZERO to only give a random number upto the > supplied bitmask > > v5: > -Updated the macro MHI_RANDOM_U32_NONZERO to take a bitmask as the input > parameter and output a non-zero value between 1 and U32_MAX > > v4: > -Dropped the change: bus: mhi: core: WARN_ON for malformed vector table > -Updated bus: mhi: core: Read transfer length from an event properly to include > parse rsc events > -Use prandom_u32_max() instead of prandom_u32 to avoid if check in > bus: mhi: core: Ensure non-zero session or sequence ID values are used > > v3: > -Fixed signed-off-by tags > -Add a refactor patch for MHI queue APIs > -Commit text fix in bus: mhi: core: Read transfer length from an event properly > -Fix channel ID range check for ctrl and data event rings processing > > v2: > -Fix channel ID range check potential infinite loop > -Add appropriate signed-off-by tags > > Bhaumik Bhatt (4): > bus: mhi: core: Handle firmware load using state worker > bus: mhi: core: Return appropriate error codes for AMSS load failure > bus: mhi: core: Improve debug logs for loading firmware > bus: mhi: core: Ensure non-zero session or sequence ID values are used > > Hemant Kumar (4): > bus: mhi: core: Refactor mhi queue APIs > bus: mhi: core: Cache intmod from mhi event to mhi channel > bus: mhi: core: Add range check for channel id received in event ring > bus: mhi: core: Read transfer length from an event properly > > drivers/bus/mhi/core/boot.c | 75 +++++++++---------- > drivers/bus/mhi/core/init.c | 5 +- > drivers/bus/mhi/core/internal.h | 5 +- > drivers/bus/mhi/core/main.c | 156 +++++++++++++++++++++------------------- > drivers/bus/mhi/core/pm.c | 6 +- > include/linux/mhi.h | 2 - > 6 files changed, 129 insertions(+), 120 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project