Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp266184ybk; Sat, 9 May 2020 02:13:14 -0700 (PDT) X-Google-Smtp-Source: APiQypI2rLinLmTssc3EI5rxXFueFsf1bZKgZJhOX6zhxuVAQiTDiSuC9xp5ej+e/TVumn9ipwAN X-Received: by 2002:aa7:c3c2:: with SMTP id l2mr5480514edr.362.1589015594198; Sat, 09 May 2020 02:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589015594; cv=none; d=google.com; s=arc-20160816; b=B/vlVouViLMRz1AbQssbtlr+3aTGeAG9c95bOHubSOQ0xVFyBgZuBeEtXKulhx1hu9 vJnxQYN/69uaFWY/GuZKpbLlhC1mZb3zMbVZM62GDPnO/S2adufyqadmmf6J5SotZsnO hWVpXiJZ6tBBQe38wnHYnB/7lKZUUyybSRq3ouG1VWRrTZqOFVpnbWV7OdIW7FrAlO2I 3xzi9Rkpg/2yFqfVISGJjd2FlmzWT1RYuMp311BI66FyW9W+82xjFNh0NEA7ZYjnZUNq OINU9u6/iar7N/60OP2Pp07PMDLIuXAHVyn9aLAeth/mvGOyXP5Dnh3ZOk215KTxv9eP YiCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=xVJZ9IEkJZ4M5YAgxzabr5xY3wtOrvNyrM+fOrGQDbg=; b=AF2S87MUIESzKx7+C2x8A1A16oLMFs8X/zCQTnNOQSHOEgs9kJ13Lamee+Hlb5Y9td uZRTvrJY/3HmFIHEe5MKBron5mosI6K7VqyggD/BAvHZkDFovFheAGdI9BcJpZ+3ldi2 5Uk/KtsqtEn6zxCzcRX1j8KHejDKhpsXKc0DpXcUgS2yJEUw4C3DV+zQPf8mBjM/qPAa 5CddYDGy2ujLJEQHOj+nDobX84TRWrLUT8gCgwjE2lpPxieSZtVU5bRoEybJ1VldRtum tNkoCzogR5C1KXa7tQh3qZn92Mmgz5h3qRfNes1mCNw6yP8hmdaHkVS0kyAGz3AdBdwl /2sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si1620411ejq.247.2020.05.09.02.12.50; Sat, 09 May 2020 02:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbgEIJLI (ORCPT + 99 others); Sat, 9 May 2020 05:11:08 -0400 Received: from server-x.ipv4.hkg02.ds.network ([27.111.83.178]:54252 "EHLO mail.gtsys.com.hk" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725930AbgEIJLI (ORCPT ); Sat, 9 May 2020 05:11:08 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.gtsys.com.hk (Postfix) with ESMTP id 5872F2003CA0; Sat, 9 May 2020 17:11:06 +0800 (HKT) X-Virus-Scanned: Debian amavisd-new at gtsys.com.hk Received: from mail.gtsys.com.hk ([127.0.0.1]) by localhost (mail.gtsys.com.hk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id odAZhTF_7maC; Sat, 9 May 2020 17:11:06 +0800 (HKT) Received: from s01.gtsys.com.hk (unknown [10.128.4.2]) by mail.gtsys.com.hk (Postfix) with ESMTP id 3627320020CB; Sat, 9 May 2020 17:11:06 +0800 (HKT) Received: from [10.128.2.32] (unknown [124.217.189.244]) by s01.gtsys.com.hk (Postfix) with ESMTPSA id 72D14C019F4; Sat, 9 May 2020 17:11:05 +0800 (HKT) Subject: Re: [PATCH v0 1/1] spi: spi-rockchip: add support for spi slave_mode To: Emil Renner Berthing Cc: Jack Lo , Heiko Stuebner , Linux Kernel Mailing List , linux-spi@vger.kernel.org, "open list:ARM/Rockchip SoC..." , Mark Brown , linux-arm-kernel References: <20200508083729.5560-1-chris.ruehl@gtsys.com.hk> <20200508083729.5560-2-chris.ruehl@gtsys.com.hk> From: Chris Ruehl Message-ID: Date: Sat, 9 May 2020 17:11:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Emil, >> + if (rs->slavemode) here is a mistake  it is :  rs->slave_mode and the use of rs->slave_mode in the rockchip_spi_config()