Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp278104ybk; Sat, 9 May 2020 02:37:09 -0700 (PDT) X-Google-Smtp-Source: APiQypIXUJcs7mANkg3G8F4FBt5UDrob7f4vC4XU/xh+1quJ1XUyWu0O/13lUUKiRpx4/HpgSoQV X-Received: by 2002:aa7:c609:: with SMTP id h9mr5450252edq.250.1589017028950; Sat, 09 May 2020 02:37:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589017028; cv=none; d=google.com; s=arc-20160816; b=RIrBAfSMj1nrzuPyXpdflmQgON3/4L2AJ4W+qdCXgfa8e06fhDTjg7fAtRvXHMDS8f 8vCW3zq1a6kdiW1cDX/KZTDK6bl9KD9AzwQWIv0qgZvY9+2nXAHIlgbf/2d3yfukeFWh zSUNG3+D2tMubjNoqhSd1lL+nkgwyIfol62l3fVNzK8AAPp2wVKLlynvq1941UMzIrJv 1ts4+QhJK7TDgHDD8MkjugiDz/vYSLvE3JmaEzqYx38xrzMQUuymC3ImuFzQ4/VyxT9n Syf3k5czI94TTPtGJWdG/d3/d3zb1QB00TITLRgG+Mr+dG5p5g/hmAxC84LpWAgtdQ93 OWXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bcyT78q3GgNpxCiC5div5KdzOezVADyQUC2qgmQBzUA=; b=0fbVspoAWRzTimoVgYaKhbvnp3GGHQy2nWD+BxuSDYTI2F2jzBByZxIBVg5AZsu24z MBtnZUGyUW7t/U7yeQ9a0OS0L9LfPYG0oCI2lJKNUsxlrGE4NHJ8EjYlrkeKekJaIZnV H8W8oeuqtc5Fz9p/Tfwk0Hxy9BrNqc5NTLBufc/GUj4iGWx4CXjh+AQMhLZL0pHe84vQ SDthGE4n6icQVHY6u1Wio+bZhYaqqAUwY69zCaICLIrjdrNT17kNcZ5tve+b4VMc88Sw gUqpMIW79gwme8iSMOdltW8r6XkNkSlYGYUNymqAHYUm3/S4/gkeCioZY6vArR/Tx308 pP2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do16si3352702ejc.265.2020.05.09.02.36.45; Sat, 09 May 2020 02:37:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727889AbgEIJfZ (ORCPT + 99 others); Sat, 9 May 2020 05:35:25 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:45888 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgEIJfZ (ORCPT ); Sat, 9 May 2020 05:35:25 -0400 Received: from 89-77-60-66.dynamic.chello.pl (89.77.60.66) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.415) id 50d46019d67d5f50; Sat, 9 May 2020 11:35:23 +0200 From: "Rafael J. Wysocki" To: Zheng Zengkai Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ACPI: debug: Make two functions static Date: Sat, 09 May 2020 11:35:22 +0200 Message-ID: <11439051.xyQN3uvUWn@kreacher> In-Reply-To: <20200507070736.25418-1-zhengzengkai@huawei.com> References: <20200507070736.25418-1-zhengzengkai@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 7, 2020 9:07:36 AM CEST Zheng Zengkai wrote: > Fix sparse warnings: > > drivers/acpi/acpi_dbg.c:748:12: warning: > symbol 'acpi_aml_init' was not declared. Should it be static? > drivers/acpi/acpi_dbg.c:774:13: warning: > symbol 'acpi_aml_exit' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai > --- > drivers/acpi/acpi_dbg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c > index 7a265c2171c0..6041974c7627 100644 > --- a/drivers/acpi/acpi_dbg.c > +++ b/drivers/acpi/acpi_dbg.c > @@ -745,7 +745,7 @@ static const struct acpi_debugger_ops acpi_aml_debugger = { > .notify_command_complete = acpi_aml_notify_command_complete, > }; > > -int __init acpi_aml_init(void) > +static int __init acpi_aml_init(void) > { > int ret; > > @@ -771,7 +771,7 @@ int __init acpi_aml_init(void) > return 0; > } > > -void __exit acpi_aml_exit(void) > +static void __exit acpi_aml_exit(void) > { > if (acpi_aml_initialized) { > acpi_unregister_debugger(&acpi_aml_debugger); > Applied as 5.8 material, thanks!