Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] sched/cputime: silence a -Wunused-function warning
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <CAKwvOd=V44ksbiffN5UYw-oVfTK_wdeP59ipWANkOUS_zavxew@mail.gmail.com>
Date:   Sat, 9 May 2020 09:12:10 -0400
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        dietmar.eggemann@arm.com, Steven Rostedt <rostedt@goodmis.org>,
        bsegall@google.com, Mel Gorman <mgorman@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        Nick Desaulniers <ndesaulniers@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A8FFFB10-A619-480C-8828-DCD471B13F91@lca.pw>
References: <1583509304-28508-1-git-send-email-cai@lca.pw>
 <CAKwvOd=V44ksbiffN5UYw-oVfTK_wdeP59ipWANkOUS_zavxew@mail.gmail.com>
To:     Peter Zijlstra <peterz@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Mar 6, 2020, at 12:13 PM, Nick Desaulniers =
<ndesaulniers@google.com> wrote:
>=20
> On Fri, Mar 6, 2020 at 7:42 AM Qian Cai <cai@lca.pw> wrote:
>>=20
>> account_other_time() is only used when CONFIG_IRQ_TIME_ACCOUNTING=3Dy =
(in
>> irqtime_account_process_tick()) or CONFIG_VIRT_CPU_ACCOUNTING_GEN=3Dy =
(in
>> get_vtime_delta()). When both are off, it will generate a compilation
>> warning from Clang,
>>=20
>> kernel/sched/cputime.c:255:19: warning: unused function
>> 'account_other_time' [-Wunused-function]
>> static inline u64 account_other_time(u64 max)
>>=20
>> Rather than wrapping around this function with a macro expression,
>>=20
>> if defined(CONFIG_IRQ_TIME_ACCOUNTING) || \
>>    defined(CONFIG_VIRT_CPU_ACCOUNTING_GEN)
>>=20
>> just use __maybe_unused for this small function which seems like a =
good
>> trade-off.
>>=20
>> Signed-off-by: Qian Cai <cai@lca.pw>
>=20
> Hi Qian, thanks for the patch!
>=20
> Generally, I'm not a fan of __maybe_unused.  It is a tool in the
> toolbox for solving this issue, but it's my least favorite.  Should
> the call sites be eliminated, this may mask an unused and entirely
> dead function from being removed.  Preprocessor guards based on config
> give more context into *why* a particular function may be unused.
>=20
> So let's take a look at the call sites of account_other_time().  Looks
> like irqtime_account_process_tick() (guarded by
> CONFIG_IRQ_TIME_ACCOUNTING) and get_vtime_delta() (guarded by
> CONFIG_VIRT_CPU_ACCOUNTING_GEN).  If it were one config guard, then I
> would prefer to move the definition to be within the same guard, just
> before the function definition that calls it, but we have a more
> complicated case here.
>=20
> The next thing I'd check to see is if there's a dependency between
> configs.  In this case, both CONFIG_IRQ_TIME_ACCOUNTING and
> CONFIG_VIRT_CPU_ACCOUNTING_GEN are defined in init/Kconfig.  In this
> case there's also no dependency between configs, so specifying one
> doesn't imply the other; so guarding on one of the two configs is also
> not an option.
>=20
> So, as much as I'm not a fan of __maybe_unused, it is indeed the
> simplest option.  Though, I'd still prefer the ifdef you describe
> instead, maybe the maintainers can provide guidance/preference?
> Otherwise,
>=20
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Peter, can you take a look at this patch when you have a chance? Having =
Clang to complain this every time is a bit annoying.

>=20
>> ---
>> kernel/sched/cputime.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
>> index cff3e656566d..85da4d6dee24 100644
>> --- a/kernel/sched/cputime.c
>> +++ b/kernel/sched/cputime.c
>> @@ -252,7 +252,7 @@ static __always_inline u64 =
steal_account_process_time(u64 maxtime)
>> /*
>>  * Account how much elapsed time was spent in steal, irq, or softirq =
time.
>>  */
>> -static inline u64 account_other_time(u64 max)
>> +static inline __maybe_unused u64 account_other_time(u64 max)
>> {
>>        u64 accounted;
>>=20
>> --
>=20
> --=20
> Thanks,
> ~Nick Desaulniers