Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp505991ybk; Sat, 9 May 2020 09:17:23 -0700 (PDT) X-Google-Smtp-Source: APiQypJvN2vEu8f8yHfa/YDoQlnd7BfaqnPnJ5IC9BcPlo0nAQNl+GGfEAQQz3WFXmUBAW93UP5n X-Received: by 2002:a17:906:ce4b:: with SMTP id se11mr7006367ejb.178.1589041043480; Sat, 09 May 2020 09:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589041043; cv=none; d=google.com; s=arc-20160816; b=0bMX9eb237q2m32ixKxVElKcAtiFsChCU202BRIMbshvUYpNPSkL4y5HhuBLihRbkX Hrgf57Moc7MmsyXrkellPMPf11rjfJDZft1jmXiXLLL7miW8BfARbjwsmkf3NKUlJNJP UHAHJu2FkGOBBp/OS3MmMRai0lx18zzPdag2mb5ofJwKZAofmeqT5LXoZaLO9vskTnlz BpQJrgEA2op0QJjsFvy/p3Cs1jWR8M6fV7IaPIbzLNM7zBMc+YL91SSokiVw2XHHjsqL M5wqShHVXFneyB5vtFkIjofdLNQMvH2uM9Cx9OHxUvZNATOKCK+Nawo4LQDJPUrsK3zB MBMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=9RfWoa+OyVYhRyq8fc6okRxutf75i2JHWqqPNgwLqfs=; b=NUMf88tqJ4PPWprvXnOezPTU+EzigvUSFTIeH0Su5/UvAiJrz3yzigFFbm3ToJunrF fEwS3H/SV5nChJlyOZUbYvGJkOaOh9hApFt+mfNfsUiwz6qMQnk0GmU9prmGFQX0XMco hCXQMwEqTcptx39wPl4D77wCRS2KsSqVRUzjtcaWUQLB4yIAwGdBFdNzliBCG5sHocHF umXWm0yiPcAHn/3Bd7LISwJzZO4jK6ax8LswqFfTf6IqpDNpdc90X3iNFvsmO5bCrbI7 kwjU7q/bRlQs9Z7ZwhV/Ur+xZG1a9WKGZBsvcxAjV1PwVuS6EzBzWO32hVxeh4bIl+mG smDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=a81IJUwF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l26si2956530eje.378.2020.05.09.09.16.59; Sat, 09 May 2020 09:17:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=a81IJUwF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728237AbgEIQPb (ORCPT + 99 others); Sat, 9 May 2020 12:15:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727787AbgEIQPb (ORCPT ); Sat, 9 May 2020 12:15:31 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B89EBC05BD09 for ; Sat, 9 May 2020 09:15:29 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id t11so2370863pgg.2 for ; Sat, 09 May 2020 09:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9RfWoa+OyVYhRyq8fc6okRxutf75i2JHWqqPNgwLqfs=; b=a81IJUwFIPM1Hc2xgPStppkTlfmxBdDHqDcxpgY/XOTG1fwZPckIMxmaW3YINucx/H kcuekRUoSNd66nE02LkNOTIxd4XqUPooYRo8WYcx8vzzDT6xbWNX0ejrbqSPv+zHTo86 QdMELaRNrcpmyyZ4bIQjSefkyz3xp5ry4wUAHVNHdfQIt9QzBGR6kk3H8NOb7fAJ4qqc NjliGsz3Harvl+UG5hvG9aAjHy2D37LAgyNDJLfhn5CVvIuEwyVauo13CtRBeAWFGwE7 1L3JVI6z1qLd5tJslvF/Fvt2Hq7qAXu5VikKYMR0Cup/xHIox+U/z89ifcqbLm6YmU9F k4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9RfWoa+OyVYhRyq8fc6okRxutf75i2JHWqqPNgwLqfs=; b=mVaexudf983ZYTLw7GaFqV3AemHSMtzhGc9VBXuW/Fltnz513DUP1vNIJMZsUoDcnl iKcnjd/eWWjtvqEyy5ihYbbN6MoY6K0pLUvL7BBAPzD1C2dsDAs6oW0k7DKo8l1akFEl M4ctXYT5+n4/zr62FghKmYqlyMIwFh0kzEH+iABeC1I+EBmfCHkwooVUxiZUWuvJRwgq nJFXwz8E533y3SMXGKILPvRcproC9dnR79/Tsdmf+5hmg0aequHD7I+v98pcabBAnsh0 1cg5fkoklBKTnLWjdYXiJzgSz38AOQJVzAPXWHSOrigqjCELSagMkR42wxS7Jp8l3SKL qq3w== X-Gm-Message-State: AGi0Puann5+RFtXh4bszwP3T4LBilBgBrObZSvdWgskUtRUkzakwHXkS V3aEros4f79oqDFAseUg9xSBgpE3rpA= X-Received: by 2002:a62:3784:: with SMTP id e126mr8525998pfa.303.1589040927999; Sat, 09 May 2020 09:15:27 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id z1sm5162042pjn.43.2020.05.09.09.15.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 09:15:27 -0700 (PDT) Subject: Re: [PATCH for-5.7] io_uring: fix zero len do_splice() To: Pavel Begunkov , Jann Horn , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <102cad76-9b98-444f-7ccf-6475245f4031@gmail.com> From: Jens Axboe Message-ID: <5c24bcbd-cb68-1929-d3f4-389fe599e8f1@kernel.dk> Date: Sat, 9 May 2020 10:15:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <102cad76-9b98-444f-7ccf-6475245f4031@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/20 10:07 AM, Pavel Begunkov wrote: > On 04/05/2020 23:00, Pavel Begunkov wrote: >> do_splice() doesn't expect len to be 0. Just always return 0 in this >> case as splice(2) do. >> > > If it was missed, may you take a look? I reattached the patch btw killing > reported warnings. Thanks for re-sending, I'll queue it up for 5.7. -- Jens Axboe