Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp527676ybk; Sat, 9 May 2020 09:57:59 -0700 (PDT) X-Google-Smtp-Source: APiQypL2Lo9vqrEMJJQDNzKe3mqSfz45utitj7QodCc1SuZkfD9/klhEMo4dX6B/9s8fFsNh/0gN X-Received: by 2002:aa7:d718:: with SMTP id t24mr6745685edq.20.1589043478927; Sat, 09 May 2020 09:57:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589043478; cv=none; d=google.com; s=arc-20160816; b=i7Orm3wckBm7occTK32Ha/Xv1TN6Vh3BoJzCTf/a3dD7Xp3jcOd+fxfE56oekwNshW /8AJWA0SSphgywGtgo32W8kpuM0j+92qRIuiM/dbFBBGw9HLXSlX4gK/Vh8gjqUiB82R 3RJnUDHLuPEVe7StjUkc5iPFNS9tEpz9frZPGQ0HfmaOzC524IQqzDpWBGXMfHIVvoX+ VLy1sbVMJOkHWziuudL5pMrTZIvnp2wa4N0WaE9EJhlVRYLoEiHopvZRipTg7gOTwmb/ gMblUqOXZ5DasJkuP9ztyw/+aKTF53V2GBvTFQq4Wl3MN/pkwT6JVwhquFQOX3JreGa0 8AAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=v9n7nUQ6BLocSh8QyJi1U2YpynP7/+J+TFH6Gxsb30Y=; b=A7/TP2T586BNCv8JuLfvd0BvbEP9YRzGAEC2hcgPMbkDSGAE9RjzMh/kFV1rHPV8Z7 b80Z4b620rBPffoCWuYPsyVXX7jozDq2tOMdLGzCsP0xLthmtwtppUZilaUUWcticFtk ib+on2ZrhfqT+b7SGk6WJPhm+wyEfcpkVgj5tSLCTn8euUpPJho/qmUQtiS6Vp3gsqlH sS/cxW2u6HwTIGEYaQI75HS/BmEywVxpHb9WEY+CFmnPFefpq1h8RYMsIn9BWB0M94CZ jxuKfUqX4eGtJ5s+omMSaXqgPXTYqF3M0e5nUVioKl63b3zV/lh1vJqmryqwPoHjwE/c j5Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=qFs16vID; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp5si2675629ejc.344.2020.05.09.09.57.33; Sat, 09 May 2020 09:57:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=qFs16vID; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbgEIQxl (ORCPT + 99 others); Sat, 9 May 2020 12:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726214AbgEIQxk (ORCPT ); Sat, 9 May 2020 12:53:40 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80340C061A0C for ; Sat, 9 May 2020 09:53:40 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id w18so2479213qvs.3 for ; Sat, 09 May 2020 09:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=v9n7nUQ6BLocSh8QyJi1U2YpynP7/+J+TFH6Gxsb30Y=; b=qFs16vID/5+OQQ9e/MZmB45bW49we+0yycpTS9fxgcC2Xn4c4+qElKzH23Ut6mnxFD dITX/LrIy8hCMLZCcSVjnfd59cG8qd3zpfgU4L/YypF613l6Yio+PcvOcZ5m2u9gaC8s 2b4E2CQ2o3Qm6BHkRqiT0H8ZsX6azu2lqIcNhqD6skcXAWLy9Ex5xfYlWtNJpJnFcc+3 17hpkUjvNeGMIQmRqaIE/72Hq36NCg0HczS+7A+go5LsSg8pTQtyB9qctfz2KjimuvoL XZHHCnBh8PQ/CIfw5PNMPFnGVlp/3AGKBN4SejYh+uB7fQI6CKjCCp/RTfG/fB6pyQE4 uHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=v9n7nUQ6BLocSh8QyJi1U2YpynP7/+J+TFH6Gxsb30Y=; b=dk7jmUgT4ZFi/emE+mOLOLvl01krpZBlxV/RZesytqgefPCpHDpeIcVAlOr1hW5ANm GLbkGEV75XetvrWOentZBXyDrGmzrR7WS8unBh7v+EL0xGJCMUaLPbHIIbXI+3Fl+mZh uCtpqHW1gkMOc5vjl1cp9pxxudnwjzGLwtoNtfFlpTvmeZnIpiXzrYeDPIgBNnX3msHP xVGCqA/9S8m8CaBkMpfoLLmW8u+Ivp+v7xatgn84oxStxCtZa92AGdOC7EJIIpU1Lozb U1usBvwGltdMSsw1RvjMNxwWQccIeyrfP9/z05JQsx3UENknSnF3D0EmMFVbSwycIq+X rNNA== X-Gm-Message-State: AGi0PuYN3MiEwrSelFRgA/BjhD4vU+3ik+qlTIaVvh6jocEqomXIP/m1 S9uSBv6/8BqSYgoDn3zWY/dHuOqJjLKFew== X-Received: by 2002:a0c:ac41:: with SMTP id m1mr8162790qvb.71.1589043219371; Sat, 09 May 2020 09:53:39 -0700 (PDT) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id 202sm3919656qko.135.2020.05.09.09.53.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 09:53:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock Date: Sat, 9 May 2020 12:53:38 -0400 Message-Id: <45D9EEEB-D887-485D-9045-417A7F2C6A1A@lca.pw> References: <20200509161217.GN2869@paulmck-ThinkPad-P72> Cc: Will Deacon , Elver Marco , LKML , Ingo Molnar , "Peter Zijlstra (Intel)" In-Reply-To: <20200509161217.GN2869@paulmck-ThinkPad-P72> To: paulmck@kernel.org X-Mailer: iPhone Mail (17D50) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On May 9, 2020, at 12:12 PM, Paul E. McKenney wrote: >=20 > Ah, and I forgot to ask. Why "if (data_race(prev->next =3D=3D node)" inst= ead > of "if (data_race(prev->next) =3D=3D node"? I think the one you suggested is slightly better to point out the exact race= . Do you want me to resend or you could squash it instead?=