Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 9 May 2020 19:39:25 +0200
From:   Helge Deller <deller@gmx.de>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Helge Deller <deller@gmx.de>,
        "James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
        linux-parisc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: suppress error messages for 'make clean'
Message-ID: <20200509173925.GA30635@ls3530.fritz.box>
References: <20200425054659.814774-1-masahiroy@kernel.org>
 <CAK7LNAQk_fLFCWuFCC0NK3nxVE0bs-n7E+T-dbn14aCZVg_pgQ@mail.gmail.com>
 <20200508214650.GA3482@ls3530.fritz.box>
 <CAK7LNAS0PVA7stUE9nmOuiP=MfPGDp1u-QDzfpk7Juq-JFehVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAS0PVA7stUE9nmOuiP=MfPGDp1u-QDzfpk7Juq-JFehVw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Masahiro Yamada <masahiroy@kernel.org>:
> Hi Helge,
>
> On Sat, May 9, 2020 at 6:46 AM Helge Deller <deller@gmx.de> wrote:
> >
> > * Masahiro Yamada <masahiroy@kernel.org>:
> > > On Sat, Apr 25, 2020 at 2:47 PM Masahiro Yamada <masahiroy@kernel.or=
g> wrote:
> > > >
> > > > 'make ARCH=3Dparisc clean' emits a tons of error messages as follo=
ws:
> > > >
> > > >   $ make ARCH=3Dparisc clean
> > > >   gcc: error: unrecognized command line option '-mno-space-regs'
> > > >   gcc: error: unrecognized command line option '-mfast-indirect-ca=
lls'; did you mean '-mforce-indirect-call'?
> > > >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> > > >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> > > >   gcc: error: unrecognized command line option '-mno-space-regs'
> > > >   gcc: error: unrecognized command line option '-mfast-indirect-ca=
lls'; did you mean '-mforce-indirect-call'?
> > > >   gcc: error: unrecognized command line option '-mdisable-fpregs'
> > > >   gcc: error: missing argument to '-Wframe-larger-than=3D'
> > > >     ...
> > > >
> > > > You can supporess them except '-Wframe-larger-than' by setting cor=
rect
> > > > CROSS_COMPILE=3D, but we should not require any compiler for clean=
ing.
> > > >
> > > > This $(shell ...) is evaluated so many times because LIBGCC is exp=
orted.
> > > > Use the ':=3D' operator to evaluate it just once, and sink the std=
err.
> > > >
> > >
> > > Applied to linux-kbuild.
> >
> > That patch breaks then building the boot loader/compressor:
> > ...
> >   hppa-linux-gnu-ld    -X -e startup --as-needed -T arch/parisc/boot/c=
ompressed/vmlinux.lds arch/parisc/boot/compressed/head.o arch/parisc/boot/=
compressed/real2.o arch/parisc/boot/compressed/firmware.o arch/parisc/boot=
/compressed/misc.o arch/parisc/boot/compressed/piggy.o -o arch/parisc/boot=
/compressed/vmlinux
> > hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `de=
c_vli':
> > (.text+0x104): undefined reference to `__ashldi3'
> > hppa-linux-gnu-ld: arch/parisc/boot/compressed/misc.o: in function `lz=
ma_len':
> > (.text+0x2b0): undefined reference to `$$mulI'
> > hppa-linux-gnu-ld: (.text+0x344): undefined reference to `$$mulI'
> > hppa-linux-gnu-ld: (.text+0x3f8): undefined reference to `$$mulI'
> >
> >
> > The patch below works, but I wonder if it's possible to avoid
> > to examine LIBGCC twice....?
> >
> > Helge
>
>
> Sorry for the breakage.
>
> How about moving LIBGCC below ?

Good idea.
The patch below does work for me.
We do not need $KBUILD_CFLAGS to get the libgcc.a filename,
so we do not need to pipe the output to /dev/null either.
Can you try if that works, and if yes, can you apply it?

Helge


diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 628cd8bb7ad8..fadbbd010337 100644
=2D-- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -21,8 +21,6 @@ KBUILD_IMAGE :=3D vmlinuz

 NM		=3D sh $(srctree)/arch/parisc/nm
 CHECKFLAGS	+=3D -D__hppa__=3D1
-LIBGCC		=3D $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
-export LIBGCC

 ifdef CONFIG_64BIT
 UTS_MACHINE	:=3D parisc64
@@ -110,6 +108,8 @@ cflags-$(CONFIG_PA8X00)		+=3D -march=3D2.0 -mschedule=
=3D8000
 head-y			:=3D arch/parisc/kernel/head.o

 KBUILD_CFLAGS	+=3D $(cflags-y)
+LIBGCC		:=3D $(shell $(CC) -print-libgcc-file-name)
+export LIBGCC

 kernel-y			:=3D mm/ kernel/ math-emu/