Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp674229ybk; Sat, 9 May 2020 15:00:50 -0700 (PDT) X-Google-Smtp-Source: APiQypJr/JzEMWA9hZJqdYu9v5rx1XHtpk/8HhioVOP1/0FC8wK8yveQoD++HNLfPIUXE+c1MFx2 X-Received: by 2002:a17:906:8609:: with SMTP id o9mr7820618ejx.361.1589061650201; Sat, 09 May 2020 15:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589061650; cv=none; d=google.com; s=arc-20160816; b=y2Zql2p/1Y2HkJ5e74ulVdmAc1QAFQLSJ4BOtG8kE49d49faaVIqikJWlT4GcWhF4k Xt2ekN1GN/FvQWHL1/6MYZz2MP/lz+G/VRvXK9ZFep0GbsehsSpKFhBQkA+D+ExmKx91 VGuFeR/hMd3hCm2ODmGRHUrCMxRKYdv7dozKlu5q5t9xYsyzDazkQK94T/3yQTcXjn0c KGnIQdJVwn0eXSLCnIYX2Lrk9AiGC7OkWYMuvnjwSHNC6A+de55PnTOwUybx13af3K2P 1jYSsbx2bzs5Jwt5IruZWckwKtmHr2At+aUy10Wc/oH+/u334B/lcxPm7NiJSAg8u8fs LNNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8BRRMTGnsc5UjSlZrSjSw4hv6MJy7/fMlV+VSqyNyeA=; b=KJNsBQZ8eTUYNMTP0GcUav4VOdaqF754qmzwQ2l1L6WZ728kTduqrzYBYG/a312Cvi JDfmfRKE76XQWSNdvCkBWZxMENwWt4edYpq+DxcSUgdhyxabeaF37Oe8SvVrTST3mZjC oWC8N5RRWLBb57jzjsf6slq50tXKLkwy1gMJy3n5nTJVt0OL3u4Cz1t3dk048O8FYx8P ZdgXXcLxRbC6vlknQfFPOPo1mWarm1rErdFcxUkwPHaSwDAEEioRJbX9Q43jQJvE/Z3c Z7dWnwRX8/qoUrr6Gl7RHMmgV08s2tQxCc+IeISQerBjQhRldhJEjYwzZeXXZgdBkzpw kEZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=K2+i6h0Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t20si3562654edy.543.2020.05.09.15.00.26; Sat, 09 May 2020 15:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=K2+i6h0Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728713AbgEIV6K (ORCPT + 99 others); Sat, 9 May 2020 17:58:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:36336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgEIV6I (ORCPT ); Sat, 9 May 2020 17:58:08 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1159320A8B; Sat, 9 May 2020 21:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589061488; bh=8LDwYge0vi4f67R9PaFiUhi9lpFstDMiQuOLGmpth7k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K2+i6h0Qfml79Q9GynUDuEHqxkFRC42Z/v4aibYZA8p+JTUZ+9dxA+4oAZ3Ec2477 MZMt2m2FmiLtUmRripbB0L640+1e5RedlLKQ+vSpGzloTIU0UHMsSMK15HJ4FJCopm 0uhWtMvUV6IWBjE4pzIntuYKps9WjI8r19kBahBA= Date: Sat, 9 May 2020 14:58:06 -0700 From: Jakub Kicinski To: Russell King - ARM Linux admin Cc: Matteo Croce , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Thomas Petazzoni , Stefan Chulski Subject: Re: [PATCH net] mvpp2: enable rxhash only on the first port Message-ID: <20200509145806.3e82a710@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200509202355.GL1551@shell.armlinux.org.uk> References: <20200509141546.5750-1-mcroce@redhat.com> <20200509202355.GL1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 May 2020 21:23:55 +0100 Russell King - ARM Linux admin wrote: > I seem to have discovered the cause of the problem in the old thread, > so I suggest we wait and see whether anyone offers up a proper > solution to this regression before we rush to completely disable > this feature. > > I would suggest with a high degress of confidence based on my > research that prior to the offending commit (895586d5dc32), rx > hashing was working fine, distributing interrupts across the cores. Ack, dropping this from patchwork for now. Thanks for the guidance.