Date: Fri, 10 Mar 2006 20:03:50 -0800
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: tim@cyberelk.net, linux-parport@lists.infradead.org,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/block/paride/pd.c: fix an off-by-one
Message-Id: <20060310200350.11127467.rdunlap@xenotime.net>
In-Reply-To: <20060311034253.GI21864@stusta.de>
References: <20060311034253.GI21864@stusta.de>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1007
Lines: 31

On Sat, 11 Mar 2006 04:42:53 +0100 Adrian Bunk wrote:

> The Coverity checker found this off-by-one error.
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c.old	2006-03-11 02:07:21.000000000 +0100
> +++ linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c	2006-03-11 02:07:50.000000000 +0100
> @@ -275,7 +275,7 @@
>  	int i;
>  
>  	printk("%s: %s: status = 0x%x =", disk->name, msg, status);
> -	for (i = 0; i < 18; i++)
> +	for (i = 0; i < 17; i++)
>  		if (status & (1 << i))
>  			printk(" %s", pd_errs[i]);
>  	printk("\n");

Please use ARRAY_SIZE(pd_errs)
and #include <linux/kernel.h>

---
~Randy
Please use an email client that implements proper (compliant) threading.
(You know who you are.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/