Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp761096ybk; Sat, 9 May 2020 18:05:54 -0700 (PDT) X-Google-Smtp-Source: APiQypL37V6BN1IdlMaKoNPCm9yma1gBW7D1woHXAYn4N4NcyUTlDsRtSnxamxkRCtyHDUgcgKiF X-Received: by 2002:a50:eacb:: with SMTP id u11mr7825519edp.162.1589072753901; Sat, 09 May 2020 18:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589072753; cv=none; d=google.com; s=arc-20160816; b=aPxTjPyjT8VGUoCRXCZ/ye4sb3PztdyixJRemfF2a5zzl9kDnD93FeVrr5LLj9O4g5 yWueuphQp/t9iBbn6xokw28/Wqk9kL1dvbX0AUhWS4g/LTN4H6SORa2hGY2gfEBUthyu l24rLEL69mYm2E+S5lINokaClEMUC0i8YxGMe4Z40hub0IeymgSvFNqDj//MEMU6TLOB bKPchGjbyFhk1jnt/cy2v/4IwRQhhCtgtYIDUgpPFd3pfMA894qjGEcloR3rUvtnYqTP 9x7KSTwmFVtSZVvHb3HpA4K8+u+vznrYckA6CITrPhsGPVKMGPIUpzs/nke9FJnidMS1 IpFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=uSW1DMa2xFD1JwY5E5sO8XesFCa8M5X82K6mPTFeOlM=; b=q/c1FQMzx3C+6ywSDKoN8i63MXOVEfHC14KaFcu33ytCgbIxUkC5a/jiYa04I1ZbFl UEPTcKlsIzfp3BrzX3oMNxIwqZAKTCPc/z3oYA8g/JZ2/QuJY6iQfQI3vWWcfXPaZumt nLLkrWxkn2i9Wa/7RGF/yEPiwUcLpEYanwWTgdZvJhSliVeF8AeWwYX5/qRpdM1k8CR5 /51Tzly91lVbP5F8+0Q9p8cW3oOCtEFqP5U2oK6WtmWQ5k77ybxhZlLc8HSWJ1MyJt35 0YwEZsa22Wu+lyFDjH/jiD9Udf7MJ30Ne6TMP83Q6c+XeX/yHFI4Q4Y9AU5HnW31q09E g17w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@pensando.io header.s=google header.b=1+Cjd90d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p63si3721196edb.61.2020.05.09.18.05.30; Sat, 09 May 2020 18:05:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@pensando.io header.s=google header.b=1+Cjd90d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgEJBBz (ORCPT + 99 others); Sat, 9 May 2020 21:01:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726320AbgEJBBz (ORCPT ); Sat, 9 May 2020 21:01:55 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389B3C061A0E for ; Sat, 9 May 2020 18:01:55 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id u10so2346413pls.8 for ; Sat, 09 May 2020 18:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=uSW1DMa2xFD1JwY5E5sO8XesFCa8M5X82K6mPTFeOlM=; b=1+Cjd90dDpebl/lpjqKbNVokRT3OdtBCX464eur5zMRwc6sunR//0hTPKyGFMBYDn+ 4s4EMDlJoNIkNgtkCHvFKvJ4BK+FSLcJcF3J0h1lFBJHpcGvBOOdoVJNuJuduxyhdptA 85j0f2zkLQyxEd/osyueYryePBBEKaHhfTf3pYUcyugloMOdyrOAfoJZ6gWHbUrjqQLj Bq4Jez4NN0LmXePlsppUQ+3lVV2FHHGMRHWmUEdUPVdDZtvm3xP30rhd+ijoCYftHXaH O/d9SbqFvB9iV52JjhqLOrwxcvZn53+35Gt30HqnEMHSXevbw+tJGlyzQoU9D+YGA4+g K2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uSW1DMa2xFD1JwY5E5sO8XesFCa8M5X82K6mPTFeOlM=; b=YAnzJvLZjr1OLPiD4rxFzpyIddsAjCZ4veLKDG6r8Rp2W8KbyrKoSL7r68pSIalvNI GcABLN3/m9XTKXWxtSBDacJATxOVr8t7o0ZGVfbbeuLT+TfSKlmnI9TvtlUGyDziyYp/ 224x6GF8Lcn+CGmehY6ePNl7BtWgZZpOzwUJan+3fxNoh/g1mspk//srjf//RZ3u4eQg ammhtDE8ljXom5lP4hfGaMfT36EWnDNkyEGfglF+DULqOJ20ysC13v7Lp5CRXiuv7cwb LYSx6i/rmU9xfPQqTIQeVAV5EkchF5c2Y4wcF6syP7N69U4ym0gIXLSL/PglEgcALaTV PQlw== X-Gm-Message-State: AGi0PuY9awP2YgqzxgrLMDf+bZRs8qIAO/NJyEGt4cmULVDM3Jo5M4UE IxNUuPXYixXQGSTevkLBp6YaAo85PIgO8A== X-Received: by 2002:a17:902:8545:: with SMTP id d5mr9040836plo.34.1589072514404; Sat, 09 May 2020 18:01:54 -0700 (PDT) Received: from Shannons-MacBook-Pro.local (static-50-53-47-17.bvtn.or.frontiernet.net. [50.53.47.17]) by smtp.gmail.com with ESMTPSA id b1sm5478906pfi.140.2020.05.09.18.01.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 18:01:53 -0700 (PDT) Subject: Re: [PATCH 00/15] net: taint when the device driver firmware crashes To: Luis Chamberlain , jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200509043552.8745-1-mcgrof@kernel.org> From: Shannon Nelson Message-ID: <1e097eb0-6132-f549-8069-d13b678183f5@pensando.io> Date: Sat, 9 May 2020 18:01:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/20 9:35 PM, Luis Chamberlain wrote: > Device driver firmware can crash, and sometimes, this can leave your > system in a state which makes the device or subsystem completely > useless. Detecting this by inspecting /proc/sys/kernel/tainted instead > of scraping some magical words from the kernel log, which is driver > specific, is much easier. So instead this series provides a helper which > lets drivers annotate this and shows how to use this on networking > drivers. > If the driver is able to detect that the device firmware has come back alive, through user intervention or whatever, should there be a way to "untaint" the kernel?  Or would you expect it to remain tainted? sln